Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753822AbbLVFhS (ORCPT ); Tue, 22 Dec 2015 00:37:18 -0500 Received: from mail-pa0-f44.google.com ([209.85.220.44]:35693 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753797AbbLVFhP (ORCPT ); Tue, 22 Dec 2015 00:37:15 -0500 Date: Mon, 21 Dec 2015 20:37:10 -0900 From: Kent Overstreet To: Junichi Nomura Cc: Tejun Heo , "Artem S. Tashkinov" , "Artem S. Tashkinov" , Christoph Hellwig , Ming Lin , Jens Axboe , Linus Torvalds , Steven Whitehouse , IDE-ML , Linux Kernel Mailing List , Ming Lei Subject: Re: IO errors after "block: remove bio_get_nr_vecs()" Message-ID: <20151222053710.GA26544@kmo-pixel> References: <20151221065528.GA3873@htj.duckdns.org> <20151221193550.GM4026@mtj.duckdns.org> <20151221200721.GN4026@mtj.duckdns.org> <20151221210811.GO4026@mtj.duckdns.org> <20151222035944.GG20661@kmo-pixel> <20151222052611.GA10487@xzibit.linux.bs1.fc.nec.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151222052611.GA10487@xzibit.linux.bs1.fc.nec.co.jp> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1707 Lines: 54 On Tue, Dec 22, 2015 at 05:26:12AM +0000, Junichi Nomura wrote: > On 12/22/15 12:59, Kent Overstreet wrote: > > reproduced it with 32 bit pae: > > > >> 1. Exclude memory above 4G line with boot param "max_addr=4G". > > > > doesn't work - max_addr=1G doesn't work either > > > >> 2. Disable highmem with "highmem=0". > > > > works! > > > >> 3. Try booting 64bit kernel. > > > > works > > blk_queue_bio() does split then bounce, which makes the segment > counting based on pages before bouncing and could go wrong. > > What do you think of a patch like this? Shit, you nailed it. Can't believe I didn't think to check that. > > -- > Jun'ichi Nomura, NEC Corporation > > diff --git a/block/blk-core.c b/block/blk-core.c > index 5131993b..1d1c3c7 100644 > --- a/block/blk-core.c > +++ b/block/blk-core.c > @@ -1689,8 +1689,6 @@ static blk_qc_t blk_queue_bio(struct request_queue *q, struct bio *bio) > struct request *req; > unsigned int request_count = 0; > > - blk_queue_split(q, &bio, q->bio_split); > - > /* > * low level driver can indicate that it wants pages above a > * certain limit bounced to low memory (ie for highmem, or even > @@ -1698,6 +1696,8 @@ static blk_qc_t blk_queue_bio(struct request_queue *q, struct bio *bio) > */ > blk_queue_bounce(q, &bio); > > + blk_queue_split(q, &bio, q->bio_split); > + > if (bio_integrity_enabled(bio) && bio_integrity_prep(bio)) { > bio->bi_error = -EIO; > bio_endio(bio); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/