Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752749AbbLVHQA (ORCPT ); Tue, 22 Dec 2015 02:16:00 -0500 Received: from mout.web.de ([212.227.17.11]:55187 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979AbbLVHP7 (ORCPT ); Tue, 22 Dec 2015 02:15:59 -0500 Subject: Re: [PATCH v2 3/4] staging: lustre: Less checks in mgc_process_recover_log() after error detection To: Greg Kroah-Hartman References: <566ABCD9.1060404@users.sourceforge.net> <566D7733.1030102@users.sourceforge.net> <56784D83.7080108@users.sourceforge.net> <56784F0C.6040007@users.sourceforge.net> <20151221234857.GA27079@kroah.com> Cc: lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, Andreas Dilger , Oleg Drokin , LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Dan Carpenter From: SF Markus Elfring X-Enigmail-Draft-Status: N1110 Message-ID: <5678F88B.7060201@users.sourceforge.net> Date: Tue, 22 Dec 2015 08:15:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151221234857.GA27079@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:8egne94FXlX1hj8ZYcgTX1UVfdQTIOhNkgSxWWnmRUCf2ET9B+u pNzbiHSNIG1h0edCewLdGPwb9pqIVtL6heU8xdjTrPv3OdXZ4tnjOAiZx/+XUvGcFwdXVaa Darw94aiErWx1548UmOrC9UDxAHBrbCgMXkdI2UfuQvkrizN1l0OqRPwzFECpYmHcKkOnrH +Uz8KZ2rFmbZE7q9vS4/w== X-UI-Out-Filterresults: notjunk:1;V01:K0:O6jOQb9z4a8=:sZ6lxksk6hhRXrpVmykX+t T9Xew5rZxw6U0U8HeRBpeP1yV4E9rugMJ63TF8R1Lq/ej8B9A6XaEr5WU4wnVHnPtrlTR1W2q ISEauk+xhNR7g9TOlfyXnSYZQcIP/0AlOeFaHxWv1SuqJnV2Wq9Jnl1DYD6j4nSScjrHam99S urTakYxdaVdlFeZs389z5Na3zcgB8vnbtFkYRkVlGTDaKVm4FbECYwDvoCVa8oeuPAj76ezX1 J8rHxOxkMghL6msanjeopqDpCCj8r7Af0XyUHGsnP4JO23lvYFeAyu1LzzcoZuAq3W2huUru6 0erQ5CfWhJg3AcjJb+7vF+6aySp+gEDKgQPwZwdxz/dxCZ2UvYTltn9Ipe7n1ShFhgnKS7tHc EPLEBIn8jO8BsDwcGuKEL7eZAmJIHa9ugkIbP5lG4ujylubDkGP+Td3lwawWTE4SoMYOiD4Db Cq4RKHfR8xJAvztJ0Zv1ZbaWxQrJO2YHR+9sTKikfi2oHmNV3X0lce04swICwwLLwaip46Pxj anp4xpMx+V096JJ2goypECsfA6agSRaaylrxKXtQqrdfUjfJEpwtsH+57kqbpA8a79gb4wnQ3 xIejUEvbUbaFcXqagP1jBSAfGev0JiBb+6mYMRAYdzsoIbBJMXVDYaZy3c6qzJrYPf4cTaoNv PELKx/g6NkIlucVJq5MTqlWs/MZNF5l0asRvYgdBudvYq/YYU/tWxb0p0/IReCHz9yBAnp1Z2 IfcgvOx59/1ApIgzeWanRtf1t0HnEGO7iBRtu4kgywaLIqJv0Nv0sgsqMlo2EGj9Wh5BUjErg udGa7T1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 696 Lines: 20 >> 6. Apply a recommendation from the script "checkpatch.pl". > > That's 6 different things, shouldn't this be 6 different patches? > > please redo. Dan Carpenter requested to squash the previous update steps 5 and 6 into a single patch for better source code review. Now I see further software development challenges to increase the patch granularity even more as you suggest. Which route would Lustre developers like to follow? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/