Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753815AbbLVI51 (ORCPT ); Tue, 22 Dec 2015 03:57:27 -0500 Received: from mga14.intel.com ([192.55.52.115]:21019 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753684AbbLVI5Z (ORCPT ); Tue, 22 Dec 2015 03:57:25 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,463,1444719600"; d="scan'208";a="846252085" Date: Tue, 22 Dec 2015 10:57:21 +0200 From: Heikki Krogerus To: Noam Camus Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com, vgupta@synopsys.com, Alexey.Brodkin@synopsys.com, jslaby@suse.com, peter@hurleysoftware.com Subject: Re: [PATCH v9 1/3] serial: 8250_dw: Avoid serial_outx code duplicate with new dw8250_check_lcr() Message-ID: <20151222085720.GA3005@kuha.fi.intel.com> References: <1449940707-17633-1-git-send-email-noamc@ezchip.com> <1449940707-17633-2-git-send-email-noamc@ezchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449940707-17633-2-git-send-email-noamc@ezchip.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 861 Lines: 27 On Sat, Dec 12, 2015 at 07:18:25PM +0200, Noam Camus wrote: > From: Noam Camus > > With the help of Heikki we take common code that > makes sure LCR write wasn't ignored and put it in new function called > dw8250_check_lcr(). This function serves 3 serial_out routines: > dw8250_serial_out(), dw8250_serial_out32(), and dw8250_serial_outq(). > > This patch only brings better code reuse. > > Signed-off-by: Noam Camus > Cc: Heikki Krogerus For all tree: Reviewed-by: Heikki Krogerus Thanks, -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/