From: Andy Yan <andy.yan@rock-chips.com>
Subject: Re: [PATCH 5/6] ARM: dts: rockchip: add reboot mode node
To: Naoki FUKAUMI <naobsd@gmail.com>
References: <1450697249-29994-1-git-send-email-andy.yan@rock-chips.com>
 <1450698149-30260-1-git-send-email-andy.yan@rock-chips.com>
 <CAFnsNoQbeAsuESSPeDDs_fQvPv96pBX=jNh=ahpWrTKLrpEExw@mail.gmail.com>
Cc: robh+dt@kernel.org, heiko@sntech.de, arnd@arndb.de, john.stultz@linaro.org,
        mark.rutland@arm.com, geert+renesas@glider.be, catalin.marinas@arm.com,
        will.deacon@arm.com, linux-kernel@vger.kernel.org,
        alexandre.belloni@free-electrons.com, lorenzo.pieralisi@arm.com,
        linux@arm.linux.org.uk, dbaryshkov@gmail.com,
        linux-rockchip@lists.infradead.org, joel@jms.id.au, treding@nvidia.com,
        wxt@rock-chips.com, devicetree@vger.kernel.org, khilman@linaro.org,
        pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
        akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org,
        moritz.fischer@ettus.com, gregkh@linuxfoundation.org, sjg@chromium.org,
        sre@kernel.org, galak@codeaurora.org, olof@lixom.net,
        jun.nie@linaro.org
Message-ID: <5679122A.2070700@rock-chips.com>
Date: Tue, 22 Dec 2015 17:04:42 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <CAFnsNoQbeAsuESSPeDDs_fQvPv96pBX=jNh=ahpWrTKLrpEExw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2555
Lines: 75

Hi,

On 2015年12月22日 11:04, Naoki FUKAUMI wrote:
> hi,
>
> On Mon, Dec 21, 2015 at 8:42 PM, Andy Yan<andy.yan@rock-chips.com>  wrote:
>> Add reboot mode driver DT node for rk3xxx,rk3288 platform
>>
>> Signed-off-by: Andy Yan<andy.yan@rock-chips.com>
>> ---
>>
>>   arch/arm/boot/dts/rk3288.dtsi                | 25 +++++++++++++++++++++++
>>   arch/arm/boot/dts/rk3xxx.dtsi                | 26 ++++++++++++++++++++++++
>>   include/dt-bindings/soc/rockchip_boot-mode.h | 30 ++++++++++++++++++++++++++++
>>   3 files changed, 81 insertions(+)
>>   create mode 100644 include/dt-bindings/soc/rockchip_boot-mode.h
>>
>> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
>> index 04ea209..937ba4c 100644
>> --- a/arch/arm/boot/dts/rk3288.dtsi
>> +++ b/arch/arm/boot/dts/rk3288.dtsi
>> @@ -170,6 +170,31 @@
>>                  };
>>          };
>>
>> +       reboot_mode {
>> +               compatible = "rockchip,reboot-mode";
>> +               rockchip,regmap = <&pmu>;
>> +               offset = <0x94>;
>> +               loader {
>> +                       linux,mode = "loader";
>> +                       linux,magic = <0x5242C301>;
>> +               };
>> +
>> +               maskrom {
>> +                       linux,mode = "maskrom";
>> +                       linux,magic = <0x5242C302>;
>> +               };
>> +
>> +               recovery {
>> +                       linux,mode = "recovery";
>> +                       linux,magic = <0x5242C303>;
>> +               };
>> +
>> +               fastboot {
>> +                       linux,mode = "fastboot";
>> +                       linux,magic = <0x5242C309>;
>> +               };
>> +       };
>> +
> (snip)
>
> I sometimes use 0xEF08A53C to load bootloader from SD card instead of
> on-board flash memory such as eMMC.
>   https://github.com/linux-rockchip/u-boot-rockchip/blob/u-boot-rk3288/common/cmd_rockusb.c#L893
>
> I don't know any detail about this function.
> (above code says "reboot to maskrom", but it should be wrong from my experience)
>
> do you know something about this function? can you handle this too?
>
> Regards,
>
>
>
  Have some discussion with the bootloader engineer, the correct magic  
number to
  reboot the system to maskrom mode is 0xEF08A53C. I will  fix it in 
next version.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/