Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754012AbbLVJrT (ORCPT ); Tue, 22 Dec 2015 04:47:19 -0500 Received: from mail-yk0-f174.google.com ([209.85.160.174]:35460 "EHLO mail-yk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751282AbbLVJrQ (ORCPT ); Tue, 22 Dec 2015 04:47:16 -0500 MIME-Version: 1.0 In-Reply-To: <56789147.8070602@mleia.com> References: <1450716100-13688-1-git-send-email-aleksey.makarov@linaro.org> <1450716100-13688-2-git-send-email-aleksey.makarov@linaro.org> <56789147.8070602@mleia.com> Date: Tue, 22 Dec 2015 11:47:15 +0200 Message-ID: Subject: Re: [PATCH v3 1/3] ACPI: amba bus probing support From: Andy Shevchenko To: Vladimir Zapolskiy Cc: Aleksey Makarov , "linux-acpi@vger.kernel.org" , Russell King , Graeme Gregory , Greg Kroah-Hartman , "Rafael J . Wysocki" , "linux-kernel@vger.kernel.org" , Shannon Zhao , "linux-serial@vger.kernel.org" , linux-arm Mailing List , Len Brown Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1373 Lines: 36 On Tue, Dec 22, 2015 at 1:54 AM, Vladimir Zapolskiy wrote: > On 21.12.2015 18:41, Aleksey Makarov wrote: >> +static int amba_handler_attach(struct acpi_device *adev, >> + const struct acpi_device_id *id) >> +{ >> + struct amba_device *dev = NULL; >> + struct acpi_device *acpi_parent; >> + struct resource_entry *rentry; >> + struct list_head resource_list; >> + struct resource *resources = NULL; >> + bool address_found = false; >> + int ret, count, irq_no = 0; >> + >> + /* If the ACPI node already has a physical device attached, skip it. */ >> + if (adev->physical_node_count) >> + return 0; >> + >> + amba_register_dummy_clk(); > > Since it is a single time dummy clock registration, may be it is better > to move it to acpi_amba_init() or somewhere else? I understand that > "apb_pclk" is wanted, but I'm not sure that this driver should serve as > a clock provider. Depends on actual hardware topology. Intel HW has few drivers that are clock providers because they are really ones. -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/