Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754941AbbLVMYt (ORCPT ); Tue, 22 Dec 2015 07:24:49 -0500 Received: from mail.kernel.org ([198.145.29.136]:35834 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754080AbbLVMYr (ORCPT ); Tue, 22 Dec 2015 07:24:47 -0500 Date: Tue, 22 Dec 2015 20:24:35 +0800 From: Shawn Guo To: Damien Riegel Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sascha Hauer , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , kernel@savoirfairelinux.com Subject: Re: [PATCH 1/2] ARM: dts: ts-4800: Add LCD support Message-ID: <20151222122435.GE26290@tiger> References: <1450458033-30471-1-git-send-email-damien.riegel@savoirfairelinux.com> <20151221133519.GC18410@tiger> <20151221184057.GE12696@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151221184057.GE12696@localhost> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1973 Lines: 60 On Mon, Dec 21, 2015 at 01:40:59PM -0500, Damien Riegel wrote: > > > @@ -30,6 +30,60 @@ > > > clock-frequency = <24576000>; > > > }; > > > }; > > > + > > > + regulators { > > > + compatible = "simple-bus"; > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + backlight_reg: regulator@0 { > > > + compatible = "regulator-fixed"; > > > + reg = <0>; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&pinctrl_enable_lcd>; > > > + regulator-name = "enable_lcd_reg"; > > > + regulator-min-microvolt = <3300000>; > > > + regulator-max-microvolt = <3300000>; > > > + gpio = <&gpio4 9 GPIO_ACTIVE_HIGH>; > > > + enable-active-high; > > > + }; > > > + }; > > > > DT maintainers dislike this fake simple-bus container. Let's put the > > regulator directly under root like below. > > > > backlight_reg: regulator-backlight { > > compatible = "regulator-fixed"; > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_enable_lcd>; > > regulator-name = "enable_lcd_reg"; > > regulator-min-microvolt = <3300000>; > > regulator-max-microvolt = <3300000>; > > gpio = <&gpio4 9 GPIO_ACTIVE_HIGH>; > > enable-active-high; > > }; > > > > I fixed it up and applied both patches. > > Thank you. I am using the imx51-*.dts as examples, maybe they should be > updated to be consistent with the newer device tree style? I'm willing > to do that but I don't want to make changes on dts files that I can't > test. Leave them there for now. > > Sidenote: your Signed-off-by is missing on these two patches. Oops. Thanks. Fixed now. Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/