Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755166AbbLVM1E (ORCPT ); Tue, 22 Dec 2015 07:27:04 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:35760 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751833AbbLVM1B (ORCPT ); Tue, 22 Dec 2015 07:27:01 -0500 From: "Jingoo Han" To: "'Yakir Yang'" , "'Inki Dae'" , "'Mark Yao'" , "'Heiko Stuebner'" Cc: "'Thierry Reding'" , "'Krzysztof Kozlowski'" , "'Rob Herring'" , "'Russell King'" , , "'Gustavo Padovan'" , "'Kishon Vijay Abraham I'" , , "'Andy Yan'" , , , , , , , "'Jingoo Han'" References: <1450236018-1118-1-git-send-email-ykk@rock-chips.com> <1450238257-3274-1-git-send-email-ykk@rock-chips.com> In-Reply-To: <1450238257-3274-1-git-send-email-ykk@rock-chips.com> Subject: Re: [PATCH v11 17/19] drm: bridge: analogix/dp: expand the look time for waiting AUX CH reply Date: Tue, 22 Dec 2015 21:26:52 +0900 Message-ID: <000a01d13cb4$0f81f510$2e85df30$@com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: AdE3tjVnJ7o1B42HQEuMhF3Dd8r7sQE/XqOg Content-Language: ko Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2278 Lines: 65 On Wednesday, December 16, 2015 12:58 PM, Yakir Yang wrote: > > After test on rockchiop platform, i found sometims driver would failed > at reading EDID message. After debugging more, i found that it's okay > to read_a byte from i2c, but it would failed at AUX transcation if we > try to ready multi-bytes from i2c. > > Driver just can't received the AUX CH reply command, even no AUX error > code. I may guess that the AUX wait time is not enough, so I try to > expand the AUX wait time, and i do see this could fix the EDID read > failed at rockchip platform. > > And I thought that expand the wait time won't hurt Exynos platform too > much, cause Exynos didn't have this problem, then driver would received > the reply command very soon, so no more additional wait time would bring > to Exynos platform. > > Signed-off-by: Yakir Yang > --- > Changes in v11: None > Changes in v10: None > Changes in v9: None > Changes in v8: None > Changes in v7: None > Changes in v6: None > Changes in v5: None > Changes in v4: None > Changes in v3: None > Changes in v2: None > > drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > index c7e2959..dc376bd 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c > @@ -482,7 +482,7 @@ int analogix_dp_start_aux_transaction(struct analogix_dp_device *dp) > reg = readl(dp->reg_base + ANALOGIX_DP_INT_STA); > while (!(reg & RPLY_RECEIV)) { > timeout_loop++; > - if (DP_TIMEOUT_LOOP_COUNT < timeout_loop) { > + if (DP_TIMEOUT_LOOP_COUNT * 10 < timeout_loop) { No, I hate this coding. analogix_dp_reg.c is the common code that can be shared by various SoCs. Please, find another way. Best regards, Jingoo Han > dev_err(dp->dev, "AUX CH command reply failed!\n"); > return -ETIMEDOUT; > } > -- > 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/