Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932335AbbLVMku (ORCPT ); Tue, 22 Dec 2015 07:40:50 -0500 Received: from lists.s-osg.org ([54.187.51.154]:59915 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753822AbbLVMks (ORCPT ); Tue, 22 Dec 2015 07:40:48 -0500 Subject: Re: next-20151222 - compile failure in drivers/media/usb/uvc/uvc_driver.c To: Valdis Kletnieks , Laurent Pinchart References: <75073.1450779516@turing-police.cc.vt.edu> Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org From: Javier Martinez Canillas X-Enigmail-Draft-Status: N1110 Message-ID: <567944CB.4070505@osg.samsung.com> Date: Tue, 22 Dec 2015 09:40:43 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <75073.1450779516@turing-police.cc.vt.edu> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1289 Lines: 39 Hello Valdis, On 12/22/2015 07:18 AM, Valdis Kletnieks wrote: > next-20151222 fails to build for me: > > CC drivers/media/usb/uvc/uvc_driver.o > drivers/media/usb/uvc/uvc_driver.c: In function 'uvc_probe': > drivers/media/usb/uvc/uvc_driver.c:1941:32: error: 'struct uvc_device' has no member named 'mdev' > if (media_device_register(&dev->mdev) < 0) > ^ > scripts/Makefile.build:258: recipe for target 'drivers/media/usb/uvc/uvc_driver.o' failed > > 'git blame' points at that line being added in: > > commit 1590ad7b52714fddc958189103c95541b49b1dae > Author: Javier Martinez Canillas > Date: Fri Dec 11 20:57:08 2015 -0200 > > [media] media-device: split media initialization and registration > > Not sure what went wrong here. > It was my forgetting to test with !CONFIG_MEDIA_CONTROLLER... Anyways, I've already posted a fix for this: https://lkml.org/lkml/2015/12/21/224 Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/