Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932767AbbLVMrX (ORCPT ); Tue, 22 Dec 2015 07:47:23 -0500 Received: from mail-oi0-f45.google.com ([209.85.218.45]:34180 "EHLO mail-oi0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbbLVMrV (ORCPT ); Tue, 22 Dec 2015 07:47:21 -0500 MIME-Version: 1.0 In-Reply-To: <1450715988-4770-4-git-send-email-Julia.Lawall@lip6.fr> References: <1450715988-4770-1-git-send-email-Julia.Lawall@lip6.fr> <1450715988-4770-4-git-send-email-Julia.Lawall@lip6.fr> Date: Tue, 22 Dec 2015 13:47:21 +0100 Message-ID: Subject: Re: [PATCH 3/5] pinctrl: sh-pfc: add missing of_node_put From: Linus Walleij To: Julia Lawall , Geert Uytterhoeven Cc: Laurent Pinchart , kernel-janitors@vger.kernel.org, "linux-sh@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 752 Lines: 21 On Mon, Dec 21, 2015 at 5:39 PM, Julia Lawall wrote: > for_each_child_of_node performs an of_node_get on each iteration, so a > goto out of the loop requires an of_node_put. > > A simplified version of the semantic patch that fixes this problem is as > follows (http://coccinelle.lip6.fr): Patch applied with Laurent's ACK. Geert: since I don't think you're gonna send me more pull requests before the merge window I went ahead and applied this directly, OK? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/