Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754260AbbLVNXF (ORCPT ); Tue, 22 Dec 2015 08:23:05 -0500 Received: from mail-io0-f172.google.com ([209.85.223.172]:33156 "EHLO mail-io0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752515AbbLVNXC (ORCPT ); Tue, 22 Dec 2015 08:23:02 -0500 MIME-Version: 1.0 In-Reply-To: References: <1450715988-4770-1-git-send-email-Julia.Lawall@lip6.fr> <1450715988-4770-4-git-send-email-Julia.Lawall@lip6.fr> Date: Tue, 22 Dec 2015 14:23:00 +0100 X-Google-Sender-Auth: qzOCTPFIp5E64sya6H5Ol0jY_2c Message-ID: Subject: Re: [PATCH 3/5] pinctrl: sh-pfc: add missing of_node_put From: Geert Uytterhoeven To: Linus Walleij Cc: Julia Lawall , Geert Uytterhoeven , Laurent Pinchart , "kernel-janitors@vger.kernel.org" , "linux-sh@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1218 Lines: 35 Hi Linus, On Tue, Dec 22, 2015 at 1:47 PM, Linus Walleij wrote: > On Mon, Dec 21, 2015 at 5:39 PM, Julia Lawall wrote: >> for_each_child_of_node performs an of_node_get on each iteration, so a >> goto out of the loop requires an of_node_put. >> >> A simplified version of the semantic patch that fixes this problem is as >> follows (http://coccinelle.lip6.fr): > > Patch applied with Laurent's ACK. > > Geert: since I don't think you're gonna send me more pull > requests before the merge window I went ahead and applied > this directly, OK? You're reading my mind ;-) Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/