Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754038AbbLVNgw (ORCPT ); Tue, 22 Dec 2015 08:36:52 -0500 Received: from mail-vk0-f47.google.com ([209.85.213.47]:33261 "EHLO mail-vk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752780AbbLVNgv (ORCPT ); Tue, 22 Dec 2015 08:36:51 -0500 MIME-Version: 1.0 In-Reply-To: References: <1450437573-32079-1-git-send-email-matthias.bgg@gmail.com> From: Daniel Kurtz Date: Tue, 22 Dec 2015 21:36:30 +0800 X-Google-Sender-Auth: BbBlDACbgwdu-ZoyOVNkV5eaVtw Message-ID: Subject: Re: [PATCH] soc: mediatek: SCPSYS: use builtin_platform_driver To: Matthias Brugger Cc: "moderated list:ARM/Mediatek SoC support" , Sascha Hauer , Arnd Bergmann , paul.gortmaker@windriver.com, =?UTF-8?B?RWRkaWUgSHVhbmcgKOm7g+aZuuWCkSk=?= , James Liao , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1325 Lines: 41 Hi Matthias, One thing below is missing from this version of the patch... > On Fri, Dec 18, 2015 at 7:19 PM, Matthias Brugger > wrote: >> SCPSYS can't be built as module. Use builtin_platform_driver instead. >> For this probe must not be __init and the data accessed can't be >> __initconst. Remove this macros. To make the impact as small as possible, >> fold scp_domain_data into scp_domain via a pointer. [snip] >> @@ -542,10 +533,11 @@ static const struct of_device_id of_scpsys_match_tbl[] = { >> }; >> >> static struct platform_driver scpsys_drv = { >> + .probe = scpsys_probe, >> .driver = { >> .name = "mtk-scpsys", This was in Sascha's version of the patch: .suppress_bind_attrs = true, Do we still need it now that we use "builtin_platform_driver"? >> .owner = THIS_MODULE, >> .of_match_table = of_match_ptr(of_scpsys_match_tbl), >> }, >> }; >> -builtin_platform_driver_probe(scpsys_drv, scpsys_probe); >> +builtin_platform_driver(scpsys_drv); >> -- >> 2.6.2 >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/