Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932773AbbLVO1a (ORCPT ); Tue, 22 Dec 2015 09:27:30 -0500 Received: from mga03.intel.com ([134.134.136.65]:26098 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932164AbbLVO11 (ORCPT ); Tue, 22 Dec 2015 09:27:27 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,464,1444719600"; d="scan'208";a="622245893" Subject: Re: [PATCH v2 1/2] crypto: KEYS: convert public key to the akcipher api To: Herbert Xu , Tadeusz Struk References: <201512200735.x3U85zQL%fengguang.wu@intel.com> <5678684F.2020308@gmail.com> <20151222120919.GA25163@gondor.apana.org.au> Cc: kbuild test robot , kbuild-all@01.org, linux-kernel@vger.kernel.org, dhowells@redhat.com, linux-security-module@vger.kernel.org, linux-crypto@vger.kernel.org, zohar@linux.vnet.ibm.com From: Tadeusz Struk Message-ID: <56795CFF.1080106@intel.com> Date: Tue, 22 Dec 2015 06:23:59 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151222120919.GA25163@gondor.apana.org.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 976 Lines: 25 Hi Herbert On 12/22/2015 04:09 AM, Herbert Xu wrote: > On Mon, Dec 21, 2015 at 12:59:59PM -0800, Tadeusz Struk wrote: >> >> The previous patch was broken, re-sending again, sorry. >> >> I think there is something missing in this configuration. >> cat .config | grep KEXEC_BZIMAGE_VERIFY_SIG gives nothing. >> Anyways, this patch should fix it. > > No this is unacceptable. Please fix it properly by making the > header file self-contained, e.g., by using a forward declaration. What about the first two. This one is completely unrelated. It only supposed to fix some random configuration issue reported by a build robot, which isn't really important now. The other two convert the module verifier to the new API. Thanks, -- TS -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/