Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755317AbbLVPvP (ORCPT ); Tue, 22 Dec 2015 10:51:15 -0500 Received: from mail.windriver.com ([147.11.1.11]:49147 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754787AbbLVPvN (ORCPT ); Tue, 22 Dec 2015 10:51:13 -0500 Date: Tue, 22 Dec 2015 10:48:08 -0500 From: Paul Gortmaker To: Daniel Kurtz CC: Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , Sascha Hauer , Arnd Bergmann , Eddie Huang =?utf-8?B?KOm7g+aZuuWCkSk=?= , James Liao , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] soc: mediatek: SCPSYS: use builtin_platform_driver Message-ID: <20151222154808.GC12458@windriver.com> References: <1450437573-32079-1-git-send-email-matthias.bgg@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1919 Lines: 54 [Re: [PATCH] soc: mediatek: SCPSYS: use builtin_platform_driver] On 22/12/2015 (Tue 21:36) Daniel Kurtz wrote: > Hi Matthias, > > One thing below is missing from this version of the patch... > > > On Fri, Dec 18, 2015 at 7:19 PM, Matthias Brugger > > wrote: > >> SCPSYS can't be built as module. Use builtin_platform_driver instead. > >> For this probe must not be __init and the data accessed can't be > >> __initconst. Remove this macros. To make the impact as small as possible, > >> fold scp_domain_data into scp_domain via a pointer. > > [snip] > > >> @@ -542,10 +533,11 @@ static const struct of_device_id of_scpsys_match_tbl[] = { > >> }; > >> > >> static struct platform_driver scpsys_drv = { > >> + .probe = scpsys_probe, > >> .driver = { > >> .name = "mtk-scpsys", > > This was in Sascha's version of the patch: > > .suppress_bind_attrs = true, Unless you've got a very specific use case where an unbind makes sense (like a quad port ethernet card, where you unbind one port and then do PCI pass through of it to a kvm guest for example) then yes, you should suppress unbind. So for most drivers aimed at a single device, or where being built in but unbinding just makes no sense for any possible use case, then yes you should set the above. Paul. -- > > Do we still need it now that we use "builtin_platform_driver"? > > >> .owner = THIS_MODULE, > >> .of_match_table = of_match_ptr(of_scpsys_match_tbl), > >> }, > >> }; > >> -builtin_platform_driver_probe(scpsys_drv, scpsys_probe); > >> +builtin_platform_driver(scpsys_drv); > >> -- > >> 2.6.2 > >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/