Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933430AbbLVSUu (ORCPT ); Tue, 22 Dec 2015 13:20:50 -0500 Received: from comal.ext.ti.com ([198.47.26.152]:37250 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753147AbbLVSUs (ORCPT ); Tue, 22 Dec 2015 13:20:48 -0500 From: Felipe Balbi To: Ramneek Mehresh , "linux-kernel@vger.kernel.org" CC: "stern@rowland.harvard.edu" , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" Subject: RE: [PATCH 0/7][v4] Add OTG support for FSL socs In-Reply-To: References: <1440693787-7339-1-git-send-email-ramneek.mehresh@freescale.com> <87fv1ju42r.fsf@saruman.tx.rr.com> <87a8rru3oq.fsf@saruman.tx.rr.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Tue, 22 Dec 2015 12:20:41 -0600 Message-ID: <871taepcp2.fsf@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3406 Lines: 88 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Ramneek Mehresh writes: >> -----Original Message----- >> From: Felipe Balbi [mailto:balbi@ti.com] >> Sent: Saturday, October 10, 2015 3:04 AM >> To: Mehresh Ramneek-B31383 ; linux- >> kernel@vger.kernel.org >> Cc: stern@rowland.harvard.edu; gregkh@linuxfoundation.org; linux- >> usb@vger.kernel.org; Mehresh Ramneek-B31383 >> >> Subject: Re: [PATCH 0/7][v4] Add OTG support for FSL socs >>=20 >> Felipe Balbi writes: >>=20 >> > Hi, >> > >> > Ramneek Mehresh writes: >> >> Add support for otg for all freescale socs having internal usb phy. >> >> >> >> Ramneek Mehresh (7): >> >> usb:fsl:otg: Make fsl otg driver as tristate >> >> usb:fsl:otg: Add controller version based ULPI and UTMI phy >> >> usb:fsl:otg: Add support to add/remove usb host driver >> >> usb:fsl:otg: Signal host drv when host is otg >> >> usb:fsl:otg: Modify otg_event to start host drv >> >> usb:fsl:otg: Combine host/gadget start/resume for ID change >> >> usb:fsl:otg: Add host-gadget drv sync delay >> > >> > Unless Alan's okay with the host side changes, I can't accept any of >> > these. However, I must say some of the flags you add here already >> > exist in some way, shape or form. For example, look at is_b_host flag. >> > > Could you please be more specific...which flag you think that I should >remove/I'm re-defining. The flags I'm defining are: > > have_hcd : defined in fsl specific structure for fsl specific use-case > > had_hcd: defined in fsl specific structure for fsl specific use-case > > is_otg : defined in include/linux/usb.h > > Are you suggesting using otg_port or is_b_host instead of is_otg? > > As I understand, is_b_host is specifically to check if an otg B device > is in host mode...correct? I just need a flag to check if a > controller is capable of otg operations? That's why defined "is_otg" > flag. Please suggest. no, I don't know why I made that comment. You could use otg_port, but that wouldn't look very clean. Can you resend with Alan's ack, then I'll move this series into testing/next. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWeZR5AAoJEIaOsuA1yqREZo0QAKaCDpBasrX2m5rqlyCtQHpw OdB8tuYOPRdrNYIHXaVoO2JFsvggU87fx/t+EJXRGDVU1hA5portM9BeGsPfKgdS ZLQcLsf1i12SNuw/F391zx+a3NyWSlZbL9JBMzURSQRCMA6c4dNYZwYF/Ve1AmF+ JHCrVl82dbmzv1dH9607wMhyF69dePbO5e8syvn4WcDFybBwwWISOX3BHUN8XsxR 5wW00e+ZuPvjLiC953UpdVm/5bcRXuUKHpAhfdQDOCeFRJryQGZx6wHIF22VTECF 6ZsdoRKJ7E0riCDux4x/wrD/trynwLGq8ZSmdb2yZ9LWDfFwfapWHuP2INjEu5OV w2DgI8zKVZBKnaznrpvXc9JwIOutlkFMjB+1lAgdD4RIKPswO4GEzVsgr7ye8bKU pY85CVKiF3Nre2W3KTl/7UYZ86nqZ1ccPh+Qb1l6bPN0ueF+fL6udblTEtrOw8yD 4s/K6nHYH1pKW83W91/4DojBhJUuK7xECjI70Hhf5YBCF+rQh7aW/5zywWL9H7od OkvBhaMzqTc7zUkgsuuFteu8sDeyv8VM3tgb5ZlHaQEIOzGWC26fXaUWbI+zqaqV nBnJpponbMB0IBZVWNOv+kNtSpi04z1Csp6aW/vz/nj/b9H08Z3CF4TJGN6UDxGN iYlYn7pQxP1wzSRxcaG5 =jF6D -----END PGP SIGNATURE----- --=-=-=-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/