Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754776AbbLVU6n (ORCPT ); Tue, 22 Dec 2015 15:58:43 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:55282 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752745AbbLVU6m (ORCPT ); Tue, 22 Dec 2015 15:58:42 -0500 Date: Tue, 22 Dec 2015 15:58:40 -0500 (EST) Message-Id: <20151222.155840.2274587303611570782.davem@davemloft.net> To: aryabinin@virtuozzo.com Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipv6/addrlabel: fix ip6addrlbl_get() From: David Miller In-Reply-To: <1450691685-29413-1-git-send-email-aryabinin@virtuozzo.com> References: <1450691685-29413-1-git-send-email-aryabinin@virtuozzo.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 22 Dec 2015 12:58:41 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 807 Lines: 18 From: Andrey Ryabinin Date: Mon, 21 Dec 2015 12:54:45 +0300 > ip6addrlbl_get() has never worked. If ip6addrlbl_hold() succeeded, > ip6addrlbl_get() will exit with '-ESRCH'. If ip6addrlbl_hold() failed, > ip6addrlbl_get() will use about to be free ip6addrlbl_entry pointer. > > Fix this by inverting ip6addrlbl_hold() check. > > Fixes: 2a8cc6c89039 ("[IPV6] ADDRCONF: Support RFC3484 configurable address selection policy table.") > Signed-off-by: Andrey Ryabinin Applied and queued up for -stable, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/