Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756167AbbLWAqS (ORCPT ); Tue, 22 Dec 2015 19:46:18 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:46753 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752868AbbLWAqR (ORCPT ); Tue, 22 Dec 2015 19:46:17 -0500 Date: Wed, 23 Dec 2015 00:46:02 +0000 From: Mark Brown To: chenfeng Cc: lee.jones@linaro.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, xuwei5@hisilicon.com, puck.chen@aliyun.com, yudongbin@hisilicon.com, saberlily.xia@hisilicon.com, suzhuangluan@hisilicon.com, kong.kongxinwei@hisilicon.com, xuyiping@hisilicon.com, z.liuxinliang@hisilicon.com, weidong2@hisilicon.com, w.f@huawei.com, qijiwen@hisilicon.com, peter.panshilin@hisilicon.com, dan.zhao@hisilicon.com, linuxarm@huawei.com Message-ID: <20151223004602.GN16023@sirena.org.uk> References: <1450184056-79851-1-git-send-email-puck.chen@hisilicon.com> <1450184056-79851-6-git-send-email-puck.chen@hisilicon.com> <56722B9F.8090301@hisilicon.com> <20151218175813.GE5727@sirena.org.uk> <56776B91.3030004@hisilicon.com> <56779A20.9070802@hisilicon.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nb8zVy0QMK3AA1xu" Content-Disposition: inline In-Reply-To: <56779A20.9070802@hisilicon.com> X-Cookie: Honk if you love peace and quiet. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1746 Lines: 47 --nb8zVy0QMK3AA1xu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 21, 2015 at 02:20:16PM +0800, chenfeng wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > While doing this in driver code, I found that it seems all the vendor > chip have the voltage table. So I am wondering can we add this into > the regulator framework. > We can add in the function of_get_regulation_constraints to get the > vset table. > I am not sure this is right or not. I'm just not convinced it's a good pattern to move this data out to DT, like I said in my other mail it's making the ABI bigger and I'm not sure I see much upside over putting the data in a table in DT rather than in C code. It's more parsing code and more things we really shouldn't change in future. --nb8zVy0QMK3AA1xu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWee7JAAoJECTWi3JdVIfQs0gH/1dm+g2Ahtp5WXabaGzkeHCM vnA9rwlhjqE6/I3vyLZ8bsyLhX7ayIE4KQmKZJuDavXABjSt44wcGMZ1V/zICF3d Lj+j2qDWLww6qtijtKddHW4kO14Z1nA4jUjUPJ6A1xcf2Yt+1v6qG2oGmQyQQeiV O1i58mw0QM5PNJ/x9N7pAb7yDr8+ovC+Msv+rIJyZ0cGTO++eQJiAmEBsUieE4Yg zJj+tvsG6rMUQa4lBft393iegSFvDPF/MaWoDAZYCGQCg9N+fxOPXLPnSd9A1afI 7zmvpg2lW+Ri/21FdUHqqFmuUDMdZ3a7Bx2pQTvlFdnDzLUbImfyOgnIR1ViVXA= =GfGw -----END PGP SIGNATURE----- --nb8zVy0QMK3AA1xu-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/