Subject: Re: [PATCH v2 1/2] crypto: KEYS: convert public key to the akcipher
 api
To: Herbert Xu <herbert@gondor.apana.org.au>
References: <201512200735.x3U85zQL%fengguang.wu@intel.com>
 <5678684F.2020308@gmail.com> <20151222120919.GA25163@gondor.apana.org.au>
 <56795CFF.1080106@intel.com> <20151223023343.GA31104@gondor.apana.org.au>
Cc: Tadeusz Struk <tstruk@gmail.com>, kbuild test robot <lkp@intel.com>,
        kbuild-all@01.org, linux-kernel@vger.kernel.org, dhowells@redhat.com,
        linux-security-module@vger.kernel.org, linux-crypto@vger.kernel.org,
        zohar@linux.vnet.ibm.com
From: Tadeusz Struk <tadeusz.struk@intel.com>
Message-ID: <567A29D5.8090503@intel.com>
Date: Tue, 22 Dec 2015 20:57:57 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <20151223023343.GA31104@gondor.apana.org.au>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 931
Lines: 22

On 12/22/2015 06:33 PM, Herbert Xu wrote:
>> What about the first two. This one is completely unrelated.
>> > It only supposed to fix some random configuration issue
>> > reported by a build robot, which isn't really important now.
>> > The other two convert the module verifier to the new API.
> No this compile breakage was introduced by your first two patches
> because you changed crypto/public_key.h which is used by entities
> outside of your patch.
> 
> So fix your first two patches by not breaking existing users
> of it.
Ok I can see the problem now. I just don't should not include
the asymmetric-type.h in the public_key.h and it fixes it.
Will send v3 soon.
Thanks,
-- 
TS
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/