Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933782AbbLWJVJ (ORCPT ); Wed, 23 Dec 2015 04:21:09 -0500 Received: from rtits2.realtek.com ([60.250.210.242]:33499 "EHLO rtits2.realtek.com.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933502AbbLWJUp (ORCPT ); Wed, 23 Dec 2015 04:20:45 -0500 Authenticated-By: X-SpamFilter-By: BOX Solutions SpamTrap 5.56 with qID tBN9KPDn021695, This message is accepted by code: ctloc85258 From: Hayes Wang To: Oliver Neukum CC: "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "netdev@vger.kernel.org" , "peter@lekensteyn.nl" Subject: RE: [PATCH v2] r8152: fix lockup when runtime PM is enabled Thread-Topic: [PATCH v2] r8152: fix lockup when runtime PM is enabled Thread-Index: AQHRMaoYnf1SY6s5ykW+Hxk1Ou29D57BBqoA//+amICAFjEPMP//lG0AgAGXnjD//82xgAASHnPA Date: Wed, 23 Dec 2015 09:20:25 +0000 Message-ID: <0835B3720019904CB8F7AA43166CEEB2F9547E@RTITMBSV03.realtek.com.tw> References: <1449573462-28417-1-git-send-email-peter@lekensteyn.nl> <0835B3720019904CB8F7AA43166CEEB2F8DAD9@RTITMBSV03.realtek.com.tw> <20151208143305.GB18728@al> <0835B3720019904CB8F7AA43166CEEB2F94D11@RTITMBSV03.realtek.com.tw> <1450782082.8824.23.camel@suse.com> <0835B3720019904CB8F7AA43166CEEB2F94FFF@RTITMBSV03.realtek.com.tw> <1450858813.6437.2.camel@suse.de> In-Reply-To: <1450858813.6437.2.camel@suse.de> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.177.36] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id tBN9LNeC015207 Content-Length: 944 Lines: 19 Oliver Neukum [mailto:oneukum@suse.de] > Sent: Wednesday, December 23, 2015 4:20 PM [...] > No, step (2) does not exist. Calls to suspend() and [reset_]resume() > always balance. Usually a driver shouldn't care about system suspend. > The way the driver is currently coded will also fail for Port-Power Off. It is different with Windows. The Windows would resume the device before system suspend, if the system suspend follows the autosuspend. Would this be a problem? After system suspend, the device may wake up the system when receiving any packet, not only magic packet. The wake events are different for system suspend and autosuspend. However, I couldn't change the wake event, because the autosuspend occurs first, and the suspend() is only called once. Best Regards, Hayes ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?