Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755458AbbLWJjW (ORCPT ); Wed, 23 Dec 2015 04:39:22 -0500 Received: from smtp5-g21.free.fr ([212.27.42.5]:45055 "EHLO smtp5-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755024AbbLWJjR convert rfc822-to-8bit (ORCPT ); Wed, 23 Dec 2015 04:39:17 -0500 Date: Wed, 23 Dec 2015 10:39:06 +0100 From: Jean-Francois Moine To: Liviu Dudau Cc: Russell King , Mark Yao , Heiko =?ISO-8859-1?Q?St=FCbner?= , Philipp Zabel , Daniel Vetter , David Airlie , Eric Anholt , linux-rockchip , dri-devel , LAKML , LKML Subject: Re: [PATCH v2 0/2] Improve drm_of_component_probe() and move rockchip to use it Message-Id: <20151223103906.2aae53595345240d57d57b41@free.fr> In-Reply-To: <20151222173800.GU960@e106497-lin.cambridge.arm.com> References: <1448029325-14602-1-git-send-email-Liviu.Dudau@arm.com> <20151222173800.GU960@e106497-lin.cambridge.arm.com> X-Mailer: Sylpheed 3.4.3 (GTK+ 2.24.29; armv7l-unknown-linux-gnueabihf) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2239 Lines: 70 On Tue, 22 Dec 2015 17:38:00 +0000 Liviu Dudau wrote: > On Fri, Nov 20, 2015 at 02:22:03PM +0000, Liviu Dudau wrote: > > Hello, > > > > This is v2 of the patchset trying to make drm_of_component_probe() cope with finding > > both local crtc ports and remote encoder ones. Heiko St?bner was nice enough to test > > an earlier version that was patched following Russell's suggestions on rk3288, but > > I haven't seen any reports from iMX or Armada users. > > > > Changelog: > > v2: Updated the drm_of_component_probe() comment to explain why the reference count > > is not dropped. Fixed the compare_port() function for rockchip as described by > > Russell. > > v1: Original submission. http://lists.freedesktop.org/archives/dri-devel/2015-November/094546.html > > Gentle ping, this has now been tested by Rockchip people and fixes the earlier version > that had to be reverted in mainline. Can it be included in the -next somewhere? Hi Liviu, Sorry for being a bit late. I wanted to use drm_of_component_probe() for a new DRM driver, but I could not find any way to do it: you add the "ports" nodes as components while, usually, the components are the device nodes themselves. With this simple patch: diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c index 493c05c..dbd2921 100644 --- a/drivers/gpu/drm/drm_of.c +++ b/drivers/gpu/drm/drm_of.c @@ -101,7 +101,7 @@ int drm_of_component_probe(struct device *dev, continue; } - component_match_add(dev, &match, compare_of, port); + component_match_add(dev, &match, compare_of, port->parent); of_node_put(port); } everything is easy, my DT being like: de_controller { ... ports = <&lcd0_p>; }; lcd_controller { ... lcd0_p: port { lcd0_ep: endpoint { remote-endpoint = <&hdmi_ep>; }; }; }; What was the reason to keep the "ports" node instead of the device? -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/