Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934093AbbLWK1H (ORCPT ); Wed, 23 Dec 2015 05:27:07 -0500 Received: from down.free-electrons.com ([37.187.137.238]:48868 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933251AbbLWK1E (ORCPT ); Wed, 23 Dec 2015 05:27:04 -0500 Date: Wed, 23 Dec 2015 11:27:01 +0100 From: Alexandre Belloni To: Ludovic Desroches Cc: jic23@kernel.org, nicolas.ferre@atmel.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, plagnioj@jcrosoft.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver Message-ID: <20151223102701.GH8623@piout.net> References: <1450689852-22763-1-git-send-email-ludovic.desroches@atmel.com> <1450689852-22763-2-git-send-email-ludovic.desroches@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1450689852-22763-2-git-send-email-ludovic.desroches@atmel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1175 Lines: 29 On 21/12/2015 at 10:24:08 +0100, Ludovic Desroches wrote : > +++ b/Documentation/devicetree/bindings/iio/adc/at91_adc8xx.txt > @@ -0,0 +1,27 @@ > +* AT91 SAMA5D2 Analog to Digital Converter (ADC) > + > +Required properties: > + - compatible: Should be "atmel,sama5d2-adc". > + - reg: Should contain ADC registers location and length. > + - interrupts: Should contain the IRQ line for the ADC. > + - clocks: phandles to clocks. > + - clock-names: tuple listing clock names. > + Required elements: "adc_clk", "adc_op_clk". "adc_clk" is the peripheral > + clock, "adc_clk" is the sampling clock. I think we should not have adc_op_clk but rather have a property like vf610 has fsl,adck-max-frequency. Even better, would be the ability to change it with /sys/bus/iio/devices/iio:deviceX/sampling_frequency -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/