Subject: Re: [PATCH] cpufreq/scpi: fix handling return value of
 topology_physical_package_id
To: Andrzej Hajda <a.hajda@samsung.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>
References: <1450867041-729-1-git-send-email-a.hajda@samsung.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        "open list:SYSTEM CONTROL & POWER INTERFACE (SCPI) Message..." 
	<linux-arm-kernel@lists.infradead.org>,
        "open list:CPU FREQUENCY DRIVERS" <linux-pm@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
From: Sudeep Holla <sudeep.holla@arm.com>
Organization: ARM
Message-ID: <567A7BF8.1030107@arm.com>
Date: Wed, 23 Dec 2015 10:48:24 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <1450867041-729-1-git-send-email-a.hajda@samsung.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 868
Lines: 27


On 23/12/15 10:37, Andrzej Hajda wrote:
> The function can return negative values, so its result should
> be assigned to signed variable.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
>

There has a patch posted by Dan Carpenter [1] which I reposted[2],
but it again slipped through the cracks. I will poke Rafael again on that.

[1] 
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/380292.html
[2] https://lkml.org/lkml/2015/12/15/219

-- 
Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/