Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934337AbbLWL44 (ORCPT ); Wed, 23 Dec 2015 06:56:56 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47342 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933214AbbLWL4x (ORCPT ); Wed, 23 Dec 2015 06:56:53 -0500 Date: Wed, 23 Dec 2015 11:56:32 +0000 From: Mark Brown To: Paul Kocialkowski Cc: linux-kernel@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , =?iso-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , Liam Girdwood , Milo Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Message-ID: <20151223115632.GS16023@sirena.org.uk> References: <1450868319-20513-1-git-send-email-contact@paulk.fr> <1450868319-20513-5-git-send-email-contact@paulk.fr> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vEk28Nl/eckWL8CC" Content-Disposition: inline In-Reply-To: <1450868319-20513-5-git-send-email-contact@paulk.fr> X-Cookie: Honk if you love peace and quiet. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:808::2 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1561 Lines: 45 --vEk28Nl/eckWL8CC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote: > + gpio = lp->pdata->enable_gpio; > + if (!gpio_is_valid(gpio)) > + return 0; > + > + /* Always set enable GPIO high. */ > + ret = devm_gpio_request_one(lp->dev, gpio, GPIOF_OUT_INIT_HIGH, "LP872X EN"); > + if (ret) { > + dev_err(lp->dev, "gpio request err: %d\n", ret); > + return ret; > + } This isn't really adding support for the enable GPIO as the changelog suggests, it's requesting but not managing the GPIO. Since there is core support for manging enable GPIOs this seems especially silly, please tell the core about the GPIO and then it will work at runtime too. --vEk28Nl/eckWL8CC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWeovvAAoJECTWi3JdVIfQ7UMIAIb3vSgxdrjCknsOEp7PlNYc 2yFA5tIjYndDjzIncdOngvJL1pxUYBseJSHQMMBqOqXRT3B+IVgMwGKO2KudTMeb E74/Qy4A1vkYN/bbkUr9iF2yga1sVm8l3upS2Vb1Z0OHFZuiwU0CMdR0NdFltyPC nfAsZ4AFazs6OShOWwvPDkYn0J0wA04TOYG2JG5Gf/3NB8yNT9FjqHr+n8en+Nud 7Y4sSbgPc7nXai/DZiyur4yYs1dQKPFLNSuASfqfDPsi3n0kEKUZW+3XmQl6UHes vjpQ/5uIqIYi4UUBTVqO8tL2iGRJf8dzADEWtQqhlDV5M6Fo9mWTVuTHcFwVhes= =b6j0 -----END PGP SIGNATURE----- --vEk28Nl/eckWL8CC-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/