Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934369AbbLWL7E (ORCPT ); Wed, 23 Dec 2015 06:59:04 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47379 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934347AbbLWL65 (ORCPT ); Wed, 23 Dec 2015 06:58:57 -0500 Date: Wed, 23 Dec 2015 11:58:38 +0000 From: Mark Brown To: Paul Kocialkowski Cc: linux-kernel@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , =?iso-8859-1?Q?Beno=EEt?= Cousson , Tony Lindgren , Liam Girdwood , Milo Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org Message-ID: <20151223115838.GT16023@sirena.org.uk> References: <1450868319-20513-1-git-send-email-contact@paulk.fr> <1450868319-20513-4-git-send-email-contact@paulk.fr> <20151223114126.GR16023@sirena.org.uk> <1450871420.2648.6.camel@collins> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nDmTXYS4kVhtHHfR" Content-Disposition: inline In-Reply-To: <1450871420.2648.6.camel@collins> X-Cookie: Honk if you love peace and quiet. User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:808::2 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 3/6] regulator: lp872x: Remove warning about invalid DVS GPIO X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2081 Lines: 50 --nDmTXYS4kVhtHHfR Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 23, 2015 at 12:50:20PM +0100, Paul Kocialkowski wrote: > Le mercredi 23 d=E9cembre 2015 =E0 11:41 +0000, Mark Brown a =E9crit : > > I would expect the driver at least needs to know how the pins or > > strapped, or otherwise have configuration for ignoring the input on the > > pins. This just deletes the warnings, it doesn't have any handling for > > this case that I can see. > When the DVS GPIO is invalid, lp872x_init_dvs jumps to the > set_default_dvs_mode label, which instructs the chip not to use the DVS > pin at all and do it all in software instead (by clearing the > LP8720_EXT_DVS_M bit in the LP872X_GENERAL_CFG register). > That is reflected later in the code, when setting the bucks (the DVS pin > only applies to the bucks) by checking for the LP8720_EXT_DVS_M bit on > the LP872X_GENERAL_CFG register (in lp872x_select_buck_vout_addr) to > decide whether to use software or hardware DVS selection. > As far as I understood, everything goes well when the GPIO is invalid. So please put this analysis in the changelog so that the changelog accurately reflects what the change is doing. --nDmTXYS4kVhtHHfR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWeoxuAAoJECTWi3JdVIfQi/YH/jcqPJlsU9m1FUCaGWFuowH9 0nJMQ7roEWkDbOdDLmyWAsZWGZ5smERjZe5W+EPrL6uZFolnb1m/3JXnLrs7U1Fg NDJdRzXcsdtrNvbRcOftOnEU9Q1lepQrLsukEAd7tUQw0lvCIMHG1KVdxdZiKTUh 2iM7sDymy0c4cG/z19fGV4f9iU/Zs2TO3G5Nx9owQVANw8j8/VLVoXd8r9o2Pj7M nm3tsRkbduD6yxCXtpqwjpwLjL0ImHGlJ5AUQMM5Fd8QJH7J29O71A0mNU0xqTGN RYEcqPIQatbYLl5svL4nVKjoDl3ntWycvQ1scOI/5TD7vjlmIPe2ya7yyd7JiQE= =kuyp -----END PGP SIGNATURE----- --nDmTXYS4kVhtHHfR-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/