Subject: Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to
 the akcipher api
To: Herbert Xu <herbert@gondor.apana.org.au>
References: <20151223143352.5035.85876.stgit@tstruk-mobl1>
 <20151223145130.GA2598@gondor.apana.org.au>
Cc: linux-kernel@vger.kernel.org, dhowells@redhat.com,
        linux-security-module@vger.kernel.org, linux-crypto@vger.kernel.org,
        zohar@linux.vnet.ibm.com
From: Tadeusz Struk <tadeusz.struk@intel.com>
Message-ID: <567AB6AF.4040702@intel.com>
Date: Wed, 23 Dec 2015 06:58:55 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <20151223145130.GA2598@gondor.apana.org.au>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 837
Lines: 21

On 12/23/2015 06:51 AM, Herbert Xu wrote:
>> > Changes in v4:
>> > - Flatten both patches into one to avoid bisect compilation problems.
> Why is this necessary?

Because the first patch modifies the struct public_key and removes the MPIs from it,
which the code modified in the second patch still uses. If bisect only takes the first
then the build will fail on the security/integrity/digsig_asymmetric.c as reported by
kbuild test robot:

>> security/integrity/digsig_asymmetric.c:95:5: error: 'struct public_key_signature' has no member named 'nr_mpi'
     pks.nr_mpi = 1;

Thanks,
-- 
TS
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/