Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756379AbbLWQDV (ORCPT <rfc822;w@1wt.eu>);
	Wed, 23 Dec 2015 11:03:21 -0500
Received: from mail-yk0-f170.google.com ([209.85.160.170]:35275 "EHLO
	mail-yk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756215AbbLWQDS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 23 Dec 2015 11:03:18 -0500
MIME-Version: 1.0
X-Originating-IP: [181.120.163.21]
In-Reply-To: <1450868319-20513-6-git-send-email-contact@paulk.fr>
References: <1450868319-20513-1-git-send-email-contact@paulk.fr>
	<1450868319-20513-6-git-send-email-contact@paulk.fr>
Date: Wed, 23 Dec 2015 13:03:17 -0300
Message-ID: <CABxcv=moAUEPo8sq5KhuLZChrQtwjF1aBeNvV1i8HvUnwDXMZA@mail.gmail.com>
Subject: Re: [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support,
 with basic features
From: Javier Martinez Canillas <javier@dowhile0.org>
To: Paul Kocialkowski <contact@paulk.fr>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, Milo Kim <milo.kim@ti.com>,
        Russell King <linux@arm.linux.org.uk>, Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Tony Lindgren <tony@atomide.com>, Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        =?UTF-8?Q?Beno=C3=AEt_Cousson?= <bcousson@baylibre.com>,
        Kumar Gala <galak@codeaurora.org>,
        "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 831
Lines: 27

Hello Paul,

[snip]

> +
> +&omap3_pmx_core {
> +       pinctrl-names = "default";
> +
> +       uart3_pins: pinmux_uart3_pins {
> +               pinctrl-single,pins = <
> +                       0x16e (PIN_INPUT | MUX_MODE0)           /* uart3_rx_irrx */
> +                       0x170 (PIN_OUTPUT | MUX_MODE0)          /* uart3_tx_irtx */
> +               >;

Could you please use the IOPAD mux macros from
include/dt-bindings/pinctrl/omap.h instead?

We just did a massive cleanup on the OMAP DTS to use them instead of
an offset from the padconf registers.

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/