Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756472AbbLWQLJ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 23 Dec 2015 11:11:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39180 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751882AbbLWQLH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 23 Dec 2015 11:11:07 -0500
Subject: Re: [PATCH] IB/usnic: delete unneeded IS_ERR test
To: Dave Goodell <dgoodell@cisco.com>, Julia Lawall <Julia.Lawall@lip6.fr>
References: <1450558139-466-1-git-send-email-Julia.Lawall@lip6.fr>
 <20151222152903.GA23118@DGOODELL-M-F02A.cisco.com>
Cc: Christian Benvenuti <benve@cisco.com>, kernel-janitors@vger.kernel.org,
        Sean Hefty <sean.hefty@intel.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org, Nelson Escobar <neescoba@cisco.com>
From: Doug Ledford <dledford@redhat.com>
Openpgp: id=AE6B1BDA122B23B4265B1274B826A3330E572FDD; url=pgp.mit.edu
Organization: Red Hat, Inc.
Message-ID: <567AC79A.8000306@redhat.com>
Date: Wed, 23 Dec 2015 11:11:06 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <20151222152903.GA23118@DGOODELL-M-F02A.cisco.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature";
 boundary="PQUBMw1PDrg3Iucc6e3kIDXUfvKltCFGr"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2224
Lines: 69

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--PQUBMw1PDrg3Iucc6e3kIDXUfvKltCFGr
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

On 12/22/2015 10:29 AM, Dave Goodell wrote:
> [copying Nelson too]
>=20
> On Sat, Dec 19, 2015 at 09:48:59PM +0100, Julia Lawall wrote:
>> kzalloc doesn't return ERR_PTR, so there is no need to test for it.
>>
>> The semantic match that finds this problem is as follows:
>> (http://coccinelle.lip6.fr/)
>>
>> // <smpl>
>> @@
>> expression x,e;
>> @@
>>
>> * x =3D kzalloc(...)
>> ... when !=3D x =3D e
>> * IS_ERR_OR_NULL(x)
>> // </smpl>
>>
>> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>=20
> Reviewed-by: Dave Goodell <dgoodell@cisco.com>
>=20
> -Dave
>=20

Thanks, applied.

--=20
Doug Ledford <dledford@redhat.com>
              GPG KeyID: 0E572FDD



--PQUBMw1PDrg3Iucc6e3kIDXUfvKltCFGr
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBCAAGBQJWeseaAAoJELgmozMOVy/dVMoP/3mWqaXvMNRrJ9vRXtknXXvu
kNM1/gZUJL5vbdIF0Lf5QsUFYCU9jKnUjBfvM2LuHMvdO+uTFCmOvVxqhXfFNDGn
dLOqeF1kC1grguS2Ta2dElyKFt45as8R5s4kRCXxucHmevOP4WvFe/s24EVJKFV1
rYx+Py5hvPeqQNqcLCIBSEvBglzQpsz8I7JyrqHju4t5wLJmB+KxQgHwOlcDMZkZ
Ef9VBhQJFLOq6MYx1diuuUODxd9CCMb5UOpRI2otkRgaWnUQ+b+NBvlVu6pM6NnL
pskKx/siAtFTWSPE4GTtOyND5tFyqbvKmUkgfHJ6X+A2RmZTKH42/UEaHD/6t8QO
cO2XUCdOy1jAyI3M8PZZriDBiOvOJiDIazuA3UyfU4cJIsRGgAfbvB/yZtdEiufP
mkoLKzlnTJraPZvJSlHZSPGzWUaTdSM+4tF1Hj87F6ti3h4BuQu87dv1gXj/KsXw
SjBvRpm2Zqw35L0fMno6UKePa96fSLPI1ksSMw1+EMocOMA36uUk7zfemUbWTY3m
vXgOU9JQbvGM7kPRus9ewD+U6SNNPnt32hNAEkTp2/LGAiI8tdoOjWCjwFmN021b
MA+zFFUjNDH3U2LG/mjk1WiBPdXoOZvplHlBOe6wqnO0qOKfGxvENhY+zxp7dyBk
JFZWXY3nOY0/0Xir5cJQ
=4EPa
-----END PGP SIGNATURE-----

--PQUBMw1PDrg3Iucc6e3kIDXUfvKltCFGr--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/