Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964895AbbLWRUj (ORCPT ); Wed, 23 Dec 2015 12:20:39 -0500 Received: from smtp5-g21.free.fr ([212.27.42.5]:52663 "EHLO smtp5-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753316AbbLWRUh convert rfc822-to-8bit (ORCPT ); Wed, 23 Dec 2015 12:20:37 -0500 Date: Wed, 23 Dec 2015 18:20:33 +0100 From: Jean-Francois Moine To: Liviu Dudau Cc: linux-rockchip , Daniel Vetter , LKML , dri-devel , Russell King , LAKML Subject: Re: [PATCH v2 0/2] Improve drm_of_component_probe() and move rockchip to use it Message-Id: <20151223182033.a52356408b9a81e9497464e7@free.fr> In-Reply-To: <20151223100534.GW960@e106497-lin.cambridge.arm.com> References: <1448029325-14602-1-git-send-email-Liviu.Dudau@arm.com> <20151222173800.GU960@e106497-lin.cambridge.arm.com> <20151223103906.2aae53595345240d57d57b41@free.fr> <20151223100534.GW960@e106497-lin.cambridge.arm.com> X-Mailer: Sylpheed 3.4.3 (GTK+ 2.24.29; armv7l-unknown-linux-gnueabihf) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1263 Lines: 30 On Wed, 23 Dec 2015 10:05:34 +0000 Liviu Dudau wrote: > > What was the reason to keep the "ports" node instead of the device? > > The function is an extract of common code sprinkled through a few DRM drivers, > they all used port rather than port->parent. Sorry for I could find such drivers. May you give me any pointer? > Have a look at my v2 where I've introduced two compare functions and also > modified the Rockchip compare_port() to use port->parent in the comparison. I > guess that should solve your problem. Keeping the port instead of the parent asks for more code, but, especially, it also asks for changes in the component drivers because, at bind time, in 'data', they get a port instead of the device. You might say that this could be interesting for components with many different masters (video and audio), but this could be solved adding intermediate device nodes in the DT (ports). -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/