Date: Wed, 23 Dec 2015 12:33:46 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Li Bin <huawei.libin@huawei.com>
Cc: <mingo@redhat.com>, <linux-kernel@vger.kernel.org>,
        "James Hogan" <james.hogan@imgtec.com>, <linux-metag@vger.kernel.org>
Subject: Re: [PATCH v2 2/5] metag: ftrace: fix the comments for
 ftrace_modify_code
Message-ID: <20151223123346.46bb525b@gandalf.local.home>
In-Reply-To: <1449367378-29430-3-git-send-email-huawei.libin@huawei.com>
References: <1449367378-29430-1-git-send-email-huawei.libin@huawei.com>
	<1449367378-29430-3-git-send-email-huawei.libin@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2238
Lines: 56

On Sun, 6 Dec 2015 10:02:55 +0800
Li Bin <huawei.libin@huawei.com> wrote:

> There is no need to worry about module and __init text disappearing
> case, because that ftrace has a module notifier that is called when
> a module is being unloaded and before the text goes away and this
> code grabs the ftrace_lock mutex and removes the module functions
> from the ftrace list, such that it will no longer do any
> modifications to that module's text, the update to make functions
> be traced or not is done under the ftrace_lock mutex as well.
> And by now, __init section codes should not been modified
> by ftrace, because it is black listed in recordmcount.c and
> ignored by ftrace.
> 
> Cc: James Hogan <james.hogan@imgtec.com>
> Cc: linux-metag@vger.kernel.org
> Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Li Bin <huawei.libin@huawei.com>

Hi, can I get a metag maintainer to ack this. Or you can take the patch
too.

-- Steve

> ---
>  arch/metag/kernel/ftrace.c |   11 +++++------
>  1 files changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/metag/kernel/ftrace.c b/arch/metag/kernel/ftrace.c
> index ed1d685..ac8c039 100644
> --- a/arch/metag/kernel/ftrace.c
> +++ b/arch/metag/kernel/ftrace.c
> @@ -54,12 +54,11 @@ static int ftrace_modify_code(unsigned long pc, unsigned char *old_code,
>  	unsigned char replaced[MCOUNT_INSN_SIZE];
>  
>  	/*
> -	 * Note: Due to modules and __init, code can
> -	 *  disappear and change, we need to protect against faulting
> -	 *  as well as code changing.
> -	 *
> -	 * No real locking needed, this code is run through
> -	 * kstop_machine.
> +	 * Note:
> +	 * We are paranoid about modifying text, as if a bug was to happen, it
> +	 * could cause us to read or write to someplace that could cause harm.
> +	 * Carefully read and modify the code with probe_kernel_*(), and make
> +	 * sure what we read is what we expected it to be before modifying it.
>  	 */
>  
>  	/* read the text we want to modify */

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/