Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756079AbbLWTAI (ORCPT ); Wed, 23 Dec 2015 14:00:08 -0500 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:45978 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755985AbbLWTAC (ORCPT ); Wed, 23 Dec 2015 14:00:02 -0500 Date: Wed, 23 Dec 2015 18:59:48 +0000 From: Russell King - ARM Linux To: Jean-Francois Moine Cc: Liviu Dudau , linux-rockchip , Daniel Vetter , LKML , dri-devel , LAKML Subject: Re: [PATCH v2 0/2] Improve drm_of_component_probe() and move rockchip to use it Message-ID: <20151223185948.GT8644@n2100.arm.linux.org.uk> References: <1448029325-14602-1-git-send-email-Liviu.Dudau@arm.com> <20151222173800.GU960@e106497-lin.cambridge.arm.com> <20151223103906.2aae53595345240d57d57b41@free.fr> <20151223100534.GW960@e106497-lin.cambridge.arm.com> <20151223182033.a52356408b9a81e9497464e7@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151223182033.a52356408b9a81e9497464e7@free.fr> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1392 Lines: 33 On Wed, Dec 23, 2015 at 06:20:33PM +0100, Jean-Francois Moine wrote: > On Wed, 23 Dec 2015 10:05:34 +0000 > Liviu Dudau wrote: > > > > What was the reason to keep the "ports" node instead of the device? > > > > The function is an extract of common code sprinkled through a few DRM drivers, > > they all used port rather than port->parent. > > Sorry for I could find such drivers. May you give me any pointer? imx-drm probably. > > Have a look at my v2 where I've introduced two compare functions and also > > modified the Rockchip compare_port() to use port->parent in the comparison. I > > guess that should solve your problem. > > Keeping the port instead of the parent asks for more code, but, > especially, it also asks for changes in the component drivers because, > at bind time, in 'data', they get a port instead of the device. Sorry, this doesn't make sense. You have far too many sub-clauses which mean nothing at all. Please rephrase. -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/