Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756879AbbLWWLF (ORCPT ); Wed, 23 Dec 2015 17:11:05 -0500 Received: from fallback3.mail.ru ([94.100.181.189]:47998 "EHLO fallback3.mail.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751683AbbLWWLD (ORCPT ); Wed, 23 Dec 2015 17:11:03 -0500 From: Roman Volkov To: Tony Prisk , Daniel Lezcano , Thomas Gleixner , Alexey Charkov Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Roman Volkov Subject: [PATCH v2 2/3] clocksource/vt8500: Remove the 'loops' variable Date: Thu, 24 Dec 2015 00:35:10 +0300 Message-Id: <1450906511-342-3-git-send-email-v1ron@mail.ru> X-Mailer: git-send-email 2.6.4 In-Reply-To: <1450906511-342-1-git-send-email-v1ron@mail.ru> References: <1450906511-342-1-git-send-email-v1ron@mail.ru> X-Mras: Ok Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1975 Lines: 55 From: Roman Volkov The purpose of the 'loops' variable is unclear. vt8500 hardware does not require any protections, in case if these variables intended for preventing infinite loops (identical PXA timer works perfectly without these ones). Signed-off-by: Roman Volkov --- drivers/clocksource/vt8500_timer.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/clocksource/vt8500_timer.c b/drivers/clocksource/vt8500_timer.c index dfc3bb4..eb08d96 100644 --- a/drivers/clocksource/vt8500_timer.c +++ b/drivers/clocksource/vt8500_timer.c @@ -48,18 +48,14 @@ #define TIMER_COUNT_W_ACTIVE (1 << 4) /* not ready for write */ #define TIMER_MATCH_W_ACTIVE (1 << 0) /* not ready for write */ -#define msecs_to_loops(t) (loops_per_jiffy / 1000 * HZ * t) - #define MIN_OSCR_DELTA 16 static void __iomem *regbase; static cycle_t vt8500_timer_read(struct clocksource *cs) { - int loops = msecs_to_loops(10); writel(3, regbase + TIMER_CTRL_VAL); - while ((readl((regbase + TIMER_AS_VAL)) & TIMER_COUNT_R_ACTIVE) - && --loops) + while (readl(regbase + TIMER_AS_VAL) & TIMER_COUNT_R_ACTIVE) cpu_relax(); return readl(regbase + TIMER_COUNT_VAL); } @@ -75,10 +71,8 @@ static struct clocksource clocksource = { static int vt8500_timer_set_next_event(unsigned long cycles, struct clock_event_device *evt) { - int loops = msecs_to_loops(10); cycle_t alarm = clocksource.read(&clocksource) + cycles; - while ((readl(regbase + TIMER_AS_VAL) & TIMER_MATCH_W_ACTIVE) - && --loops) + while (readl(regbase + TIMER_AS_VAL) & TIMER_MATCH_W_ACTIVE) cpu_relax(); writel((unsigned long)alarm, regbase + TIMER_MATCH_VAL); -- 2.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/