Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965677AbbLWVmW (ORCPT ); Wed, 23 Dec 2015 16:42:22 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:47316 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965660AbbLWVmV (ORCPT ); Wed, 23 Dec 2015 16:42:21 -0500 X-Originating-IP: 50.39.163.18 Date: Wed, 23 Dec 2015 13:42:12 -0800 From: Josh Triplett To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: linux-kernel@vger.kernel.org, Jeff Dike , Richard Weinberger , user-mode-linux-devel@lists.sourceforge.net, "Paul E . McKenney" , Michal Marek , Andrew Morton , Linus Torvalds , stable@vger.kernel.org Subject: Re: [PATCH v2] um: Fix build error and kconfig for i386 Message-ID: <20151223214212.GA1300@x> References: <1450875553-17717-1-git-send-email-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1450875553-17717-1-git-send-email-mic@digikod.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1682 Lines: 45 On Wed, Dec 23, 2015 at 01:59:13PM +0100, Micka?l Sala?n wrote: > Fix build error by selecting COREDUMP when X86_32 is selected: > > arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs': > (.text+0x3e62): undefined reference to `dump_emit' > arch/x86/um/built-in.o: In function `elf_core_write_extra_data': > (.text+0x3eef): undefined reference to `dump_emit' > > Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT") > Signed-off-by: Micka?l Sala?n > Cc: Jeff Dike > Cc: Richard Weinberger > Cc: Josh Triplett > Cc: Paul E. McKenney > Cc: Michal Marek > Cc: Andrew Morton > Cc: Linus Torvalds I suppose um doesn't care deeply about binary size, but ideally I would suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF. > arch/x86/um/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/x86/um/Kconfig b/arch/x86/um/Kconfig > index ed56a1c4ae73..bb7cd8b38043 100644 > --- a/arch/x86/um/Kconfig > +++ b/arch/x86/um/Kconfig > @@ -26,6 +26,7 @@ config X86_32 > select CLONE_BACKWARDS > select OLD_SIGSUSPEND3 > select OLD_SIGACTION > + select COREDUMP > > config X86_64 > def_bool 64BIT > -- > 2.6.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/