Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754907AbbLXCvC (ORCPT ); Wed, 23 Dec 2015 21:51:02 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:63588 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751086AbbLXCu7 (ORCPT ); Wed, 23 Dec 2015 21:50:59 -0500 Subject: Re: [PATCH v3 5/5] hisilicon/dts: Add hi655x pmic dts node To: Mark Brown References: <1450184056-79851-1-git-send-email-puck.chen@hisilicon.com> <1450184056-79851-6-git-send-email-puck.chen@hisilicon.com> <56722B9F.8090301@hisilicon.com> <20151218175813.GE5727@sirena.org.uk> <56776B91.3030004@hisilicon.com> <56779A20.9070802@hisilicon.com> <20151223004602.GN16023@sirena.org.uk> CC: , , , , , , , , , , , , , , , , , , , , , From: chenfeng Message-ID: <567B5BDF.2000304@hisilicon.com> Date: Thu, 24 Dec 2015 10:43:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20151223004602.GN16023@sirena.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.142.192.172] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.567B5BEC.0148,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 0a445765aaa7c0c1af7a8096541a2d0c Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1220 Lines: 32 On 2015/12/23 8:46, Mark Brown wrote: > On Mon, Dec 21, 2015 at 02:20:16PM +0800, chenfeng wrote: > > Please fix your mail client to word wrap within paragraphs at something > substantially less than 80 columns. Doing this makes your messages much > easier to read and reply to. > ok, thanks for your advice. >> While doing this in driver code, I found that it seems all the vendor >> chip have the voltage table. So I am wondering can we add this into >> the regulator framework. > >> We can add in the function of_get_regulation_constraints to get the >> vset table. > >> I am not sure this is right or not. > > I'm just not convinced it's a good pattern to move this data out to DT, > like I said in my other mail it's making the ABI bigger and I'm not sure > I see much upside over putting the data in a table in DT rather than in > C code. It's more parsing code and more things we really shouldn't > change in future. > ok. I will send the new version soon. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/