Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932797AbbLXOed (ORCPT ); Thu, 24 Dec 2015 09:34:33 -0500 Received: from mail-bn1bn0108.outbound.protection.outlook.com ([157.56.110.108]:45162 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932135AbbLXOeb (ORCPT ); Thu, 24 Dec 2015 09:34:31 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Joe.Lawrence@stratus.com; Subject: Re: [Bugfix v2 1/5] x86/irq: Do not reuse struct apic_chip_data.old_domain as temporary buffer To: Jiang Liu , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , References: <1450880014-11741-1-git-send-email-jiang.liu@linux.intel.com> CC: Jeremiah Mahler , Borislav Petkov , , Guenter Roeck , From: Joe Lawrence Message-ID: <567C026D.1070401@stratus.com> Date: Thu, 24 Dec 2015 09:34:21 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1450880014-11741-1-git-send-email-jiang.liu@linux.intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [96.252.83.116] X-ClientProxiedBy: BN3PR10CA0042.namprd10.prod.outlook.com (25.161.211.52) To BLUPR0801MB580.namprd08.prod.outlook.com (10.141.253.140) X-Microsoft-Exchange-Diagnostics: 1;BLUPR0801MB580;2:guEfElRjQovW/AQkoc4ftwm2Yub469Bi9OWUWZ1caJZzrQLkFeYoDYh5+0xnbe9XWZuS6wThPVTNlrWK/28dATHzKmV1g3FRE+YorE7yLiKlg2uotZsNGcNdX5uTciFv+H4jeaaOobds7R711PS4MQ==;3:LVtTVEf9zboLzJu8+1WK+8W9ByreY1TzNXdRF2Xnh/KG2x3+3JEvgcU0aJPAw+6/9kiKmEEIXDa7iWr/NgCwOijFVrBaPO4yBVNiuA9OSZ4nzJkJkZpPxx3XfPbfZylK;25:ERggM2zThD5aFrcw9pd0FdI0SGYwGgTbDkBduDKyD9UycuphUtaqUQBb5enlFoqjINBpel96pkJah2q+zBd7rKNJyc73UL0Q+IiTJOOSWroCCl6aN1CXe62m+AnTsEIeqt9MEBwEIDLV8a1/qUO/yWON2YW6RMxvcgXgnU55cBjtRuuxcw6FpZnLRsJZfg1M/nnCSke+iqeA2S9Qos52CScKwS6RY+8Khp/wCCjJE9YJe18vbaGk2u87BfdKcylTyBqP8kXw4alq4S0xUC6WOQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0801MB580; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0801MB580;20:tUmZV5aGLVVGgeNRNoSvMGUYAR4SGmntfDSssAYKERCwwExLeVUl73H/FR9Lo9wyuNf8oQdlIE47kT/sYwND5JL0Jeayf5jJhk1dPeAuoVpk3UajNAvYNxc1iSp+xxrvH+RaHtUAkrlzgISXDm3GVtHzY2OikK6qJsE2sP7ixw2phgyshoLzmIYr7Jrgmb9ZuEdSM/farX7WLTCdV9bidppB7+iWqojUY0RsnG8MwMSDkV+v2FmghlgW7ScIxlEQTl/w+7eWj9d0ODTBiwhSEfgh4EZSnBwpVwO0hF7DFxpCnz/QqwkKSamKtdcqhimK3Y9nbTfWSMO5Q/X1xYhqcvhsjfezrKI1UYCYPysIQkuMvLUf11Yd3r/aCuPUP5xIr9D+jsZrT0A9r/cTjqhaXEc+2qN0lNt7d3lzwaEjL52t3OZDKTB6gKuCQv2yCS+jd3HWUVa5QAdrJ92pZOD5EouizfgxWhSWHvFSx3bNb4Q7EDh80y6PgSP+8LeWuoYi;4:Ar/gyPMBpWYN3N9qGQxRSvB15cVdaBSiYUr0kKc8q3aCYWrzX8RK3dWT5QgXH6mbPn9zLO7k1vIXn4gFU07vo6JVb44NpO4b/ZW0FtNf4j9Ok2cJ89xnliyPyWaHDxoYL8dwnkwZ89BCZFuGj20DQyEUyVbs032fuhATkIE1+Uy9OQkfXygU74Bv6Qr8oaLoMdmtVkvfO23aG456z/6H/3MOERcUX+Pg1Zi3XmaYiRFotsoXPewpfn92ksRAWaWI08T+Y6/S2/D094OU48PNciNgM29VDPv+nEMXEWSuDBpbC+q2yUsbc6S4nKT5UvicSV4K6ZIJHkSgsPpuEsgLlWePR6SfoMLrDet6KOAEKA+HHsOQ21UUQ3ptK/Psf5Gb X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(10201501046)(3002001);SRVR:BLUPR0801MB580;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0801MB580; X-Forefront-PRVS: 0800C0C167 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(6049001)(377454003)(199003)(189002)(24454002)(479174004)(40100003)(83506001)(4001350100001)(54356999)(19580395003)(87976001)(586003)(50986999)(50466002)(5001770100001)(87266999)(19580405001)(76176999)(42186005)(97736004)(65816999)(86362001)(59896002)(81156007)(80316001)(65806001)(65956001)(33656002)(101416001)(66066001)(47776003)(64126003)(122386002)(77096005)(230700001)(3846002)(5008740100001)(5004730100002)(6116002)(1096002)(23746002)(189998001)(106356001)(105586002)(36756003)(92566002)(5001960100002)(2950100001)(3076002);DIR:OUT;SFP:1102;SCL:1;SRVR:BLUPR0801MB580;H:[10.211.55.6];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BLUPR0801MB580;23:UbkVZUOqZ2ZUFQeSXai0vB2c364xEIHNZdOC?= =?Windows-1252?Q?DXH/RZriiE5OnSrHOOcHQnMaqVyD2pmW320req78HZJ5ZL1aX3rZEMgX?= =?Windows-1252?Q?RHLIHCPVN04aQpMDAE7iEQbe8iRK+mPSBas6228XL7kkVniQS1UJzmo5?= =?Windows-1252?Q?54cDXjIYGSzuTznlt3VysPVlyW/B4MXl8ZtRhoqBL3LkZ6sMgkQrT95r?= =?Windows-1252?Q?LypKT4A0bRSM3bFsMFu+3tEBKWlIFpuARYQxGPBa9jpC6ffa0ZqJd1Lu?= =?Windows-1252?Q?tJ3B56vo/GoZ1BVlcwR6KKE3bxd/bx3j1jRpyjx0Spbs1kKdSSgTqbjy?= =?Windows-1252?Q?Ez9Jq+s5wO7MhetIDrqfwAkWIY5HXIC0cRp927nBPa/2d3th8Y9G3SqB?= =?Windows-1252?Q?8W8vXiWBJXokyDZR7uQkxSIVaNikF4s9IGipcfyO4AQLJ9VEPgIQypQz?= =?Windows-1252?Q?B0O2jSB5w6V+/EXi8P9svT9Wf8j+Eba+gcSwZNQostLZ16LCsYOznmLq?= =?Windows-1252?Q?7779ITZc1EgFR/KKGjqW1GL/7hw4a/55DTWi3FvQv8uyI1B3QuV192Ls?= =?Windows-1252?Q?y5f4qhIOoBN/eDPrG9ej+vcbsUko6A+zeG4JuYQle8gQwFhOoG28XqzC?= =?Windows-1252?Q?ySBW1wKF1CoxtsyigOPQicJDZqSUJfdqhv5a5V2/3g6A397xWEzqqt1r?= =?Windows-1252?Q?VzS7XWBNGWVdqOOq9O/D/iFxNOfia01z7bK0hp4l/5aFD5orIDYfP1tb?= =?Windows-1252?Q?la+YHEWW9mtBeU3Y2zE0dW2PQDkrqmy7Caw5UqIQx6JGwZdXW3gKUTQY?= =?Windows-1252?Q?feRSLh4gQ0ig+ZYFSbqJQ4+HStsEcACRQEUkmA6g3RUp2+vKUGexYM/o?= =?Windows-1252?Q?Tp8aqfqhq+QSIBQA2EApt0zEPDGjl35ipXdeiXfo7PKKsgFfbykKaEcJ?= =?Windows-1252?Q?uNprH/AJdJRGL61PpSF62VfketeV7VyT0sf3C8mtoWtLWAdBneLWf9EC?= =?Windows-1252?Q?SqB4yxmBfKUb62aDDGxAd6YUDV/ztJSl+9pSC9Jib+EF61x3L+Avovp7?= =?Windows-1252?Q?5bmIT0sMyakhKrzL7dHgE6yFTtgWYmcOddYDxV61Cgju8mSJjGnSj50H?= =?Windows-1252?Q?B6snRQqZP2KzFrwI/s5kz+3ZETOFVTTJ5FQoQ37k7Yi/8oZmZiXMJCuo?= =?Windows-1252?Q?FUBI46Zs49VDF0P/gG/GkvHs27hmNZHupRarMVadRYCo7GurBcdnXh9B?= =?Windows-1252?Q?BFW74jBOi0zo6GwR2WcKp2tcCcXBkt9WmVWntGjLxEDvkHiPUv9ly2fs?= =?Windows-1252?Q?mzp63C5M6Rb8PMK2X8y1FO2JshKlOjSjUZtYYykOPrqB8+V8CfvpHcPu?= =?Windows-1252?Q?Y9zPephWii37IQQGs8HMO+Jpi8meC9Rfy+g5KlKSOVrPZrUufbcnw0k?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR0801MB580;5:+89LcbMKJZMyAHHUm9WYiMJSzHOYGKJ/AFFDUcHbJQ3u8GGFtZukDziFOubEp7kP0yNNFG7aXdhGtmHZWnilF25eceVcVJ1tjZBfVhca8ww5Jw1/DlBhMdhthwvajjhEsjexfvziEaptibZmMGuy2w==;24:WxqbVmlF7tJErW/hZ9OmWVirl7H/M3wSDKd/fUKhA3E3kXI0/bYc4uhF75mZiStJNMkznIqgtXeYT5PZ3U3iL3Lhz7Lg7SBNn1TbHnl5fiU=;20:yMk9vLbRpAB+bXJ18BkDRN++8S3te4Xuv6ZNqkXSC5gWCCu1lArUbfMeQ4zgL8WeTa8bDmq/oAj+wV84nHkkAkn1mSFlP6BKfB0b0LCMaMDFgxjvAbGoUxCMrAmDcSvgiZ5bgBbiyTEaet1z5l6dT6beblvgrgAU8Uwk6R5DPic= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: stratus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Dec 2015 14:34:27.1018 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0801MB580 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 750 Lines: 21 On 12/23/2015 09:13 AM, Jiang Liu wrote: > Function __assign_irq_vector() makes use of apic_chip_data.old_domain > as a temporary buffer, which causes trouble to rollback logic in case of > failure. So use a dedicated temporary buffer for __assign_irq_vector(). > > Signed-off-by: Jiang Liu Hi Jiang, FWIW, my overnight testing is still running okay, so for v2: Tested-by: Joe Lawrence However, it looks like there will probably be a v3. -- Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/