Message-ID: <1450985932.11913.7.camel@collins>
Subject: Re: [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper
 support, with basic features
From: Paul Kocialkowski <contact@paulk.fr>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
        Mark Rutland <mark.rutland@arm.com>, Milo Kim <milo.kim@ti.com>,
        Russell King <linux@arm.linux.org.uk>, Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Tony Lindgren <tony@atomide.com>, Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        =?ISO-8859-1?Q?Beno=EEt?= Cousson <bcousson@baylibre.com>,
        Kumar Gala <galak@codeaurora.org>,
        "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Date: Thu, 24 Dec 2015 20:38:52 +0100
In-Reply-To: <CABxcv=moAUEPo8sq5KhuLZChrQtwjF1aBeNvV1i8HvUnwDXMZA@mail.gmail.com>
References: <1450868319-20513-1-git-send-email-contact@paulk.fr>
	 <1450868319-20513-6-git-send-email-contact@paulk.fr>
	 <CABxcv=moAUEPo8sq5KhuLZChrQtwjF1aBeNvV1i8HvUnwDXMZA@mail.gmail.com>
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature";
	boundary="=-VbzVbSVAUd6+5BOmtzcV"
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2496
Lines: 78


--=-VbzVbSVAUd6+5BOmtzcV
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

Le mercredi 23 d=C3=A9cembre 2015 =C3=A0 13:03 -0300, Javier Martinez Canil=
las a
=C3=A9crit :
> Hello Paul,
>=20
> [snip]
>=20
> > +
> > +&omap3_pmx_core {
> > +       pinctrl-names =3D "default";
> > +
> > +       uart3_pins: pinmux_uart3_pins {
> > +               pinctrl-single,pins =3D <
> > +                       0x16e (PIN_INPUT | MUX_MODE0)           /* uart=
3_rx_irrx */
> > +                       0x170 (PIN_OUTPUT | MUX_MODE0)          /* uart=
3_tx_irtx */
> > +               >;
>=20
> Could you please use the IOPAD mux macros from
> include/dt-bindings/pinctrl/omap.h instead?
>=20
> We just did a massive cleanup on the OMAP DTS to use them instead of
> an offset from the padconf registers.

Sure thing, will do in v2.

Thanks for the review!

--=20
Paul Kocialkowski, Replicant developer

Replicant is a fully free Android distribution running on several
devices, a free software mobile operating system putting the emphasis on
freedom and privacy/security.

Website: https://www.replicant.us/
Blog: https://blog.replicant.us/
Wiki/tracker/forums: https://redmine.replicant.us/


--=-VbzVbSVAUd6+5BOmtzcV
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAABAgAGBQJWfEnMAAoJEIT9weqP7pUMmQUP/j936e/+tpkQZVBukaO3FtP6
ijWEFHesx3fCWX5gy28hMVKicQZPciqAMNOzLpkUQauK5O7tWIFr2acU90B7nzP0
pBavhwQakkfGt3fDBzFF95wBmi1oGhnKshaclGyCO/qD1GcjNHOJv5BDLy0BXQLh
R8gwBn5Pj0RdEYhN5/+9v2OxJq7ymzwy4k2EvOI8/9qfbYacpoFM1HTd81voO0Mu
7CzBbEOItl8U2OsjmYcwOKFDnK2f3xrERkLQa+JfSLnC9tnnenyjizfArCTkxYwE
aWMXyHEmYk+LKPPqTzSxIi/C4xaC+924+xNbTUjxH61yXiKF8RlRmfETB4fMs3CK
msuv7MvKr32bA5wiatI1+jAJhgkl33NKbkKvCPd6Wihv9Q0o17QjkU48gRhz63wi
BBjnZFw7Fri5v+8hSWFHDKFoVVZM0KZuG3GWDbZgx0FwBUgzOtSmC09oslrXOOU+
U8K2t1H6PNVEjTVcD1dmqOZHhbl4xbwaNemhZP4EtcNH8Lxe/UJJQaDbGJXKbPnk
8gTsnW33GIncym5noI9HkYKxqcVnD6TSnBR/tPYXp/6QgHBX1P9Ak+6nHjchwlqY
qEJHuJGrQMe5eY1SOk9nJ6+FH/wKEINqWk7K9zO1ZhLXx619WrcufCsyjJtLLnGt
U8IMep7T0r5Ymhjljpq0
=Mfvc
-----END PGP SIGNATURE-----

--=-VbzVbSVAUd6+5BOmtzcV--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/