Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753984AbbLXWWL (ORCPT ); Thu, 24 Dec 2015 17:22:11 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:44406 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752215AbbLXWWI (ORCPT ); Thu, 24 Dec 2015 17:22:08 -0500 From: Guenter Roeck To: linux-watchdog@vger.kernel.org Cc: Wim Van Sebroeck , Damien Riegel , linux-kernel@vger.kernel.org, Guenter Roeck Subject: [PATCH v2 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers Date: Thu, 24 Dec 2015 14:21:59 -0800 Message-Id: <1450995724-17758-1-git-send-email-linux@roeck-us.net> X-Mailer: git-send-email 2.1.4 X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 719 Lines: 15 The 'dev' variable in watchdog drivers has a different lifetime than the watchdog character device and should therefore not be used by watchdog drivers. Some of the drivers use the variable to print kernel messages. Those messages are either dropped or changed to use the parent device. One driver sets the variable during initialization to the watchdog driver's parent device, which is wrong and was removed. v2: Use parent device for dev_XXX messages instead of pr_XXX. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/