Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754368AbbLYB00 (ORCPT ); Thu, 24 Dec 2015 20:26:26 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:38080 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752371AbbLYB0Y (ORCPT ); Thu, 24 Dec 2015 20:26:24 -0500 X-Originating-IP: 50.39.163.18 Date: Thu, 24 Dec 2015 17:26:13 -0800 From: Josh Triplett To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: linux-kernel@vger.kernel.org, Jeff Dike , Richard Weinberger , user-mode-linux-devel@lists.sourceforge.net, "Paul E . McKenney" , Michal Marek , Andrew Morton , Linus Torvalds , stable@vger.kernel.org Subject: Re: [PATCH v2] um: Fix build error and kconfig for i386 Message-ID: <20151225012613.GA12977@x> References: <1450875553-17717-1-git-send-email-mic@digikod.net> <20151223214212.GA1300@x> <567BE089.8030903@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <567BE089.8030903@digikod.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1714 Lines: 34 On Thu, Dec 24, 2015 at 01:09:45PM +0100, Micka?l Sala?n wrote: > > On 23/12/2015 22:42, Josh Triplett wrote: > > On Wed, Dec 23, 2015 at 01:59:13PM +0100, Micka?l Sala?n wrote: > >> Fix build error by selecting COREDUMP when X86_32 is selected: > >> > >> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs': > >> (.text+0x3e62): undefined reference to `dump_emit' > >> arch/x86/um/built-in.o: In function `elf_core_write_extra_data': > >> (.text+0x3eef): undefined reference to `dump_emit' > >> > >> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT") > >> Signed-off-by: Micka?l Sala?n > >> Cc: Jeff Dike > >> Cc: Richard Weinberger > >> Cc: Josh Triplett > >> Cc: Paul E. McKenney > >> Cc: Michal Marek > >> Cc: Andrew Morton > >> Cc: Linus Torvalds > > > > I suppose um doesn't care deeply about binary size, but ideally I would > > suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when > > CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF. > > That looks better! Since the first patch has been added to the mmots tree (but not yet in mmotm) I'll send a patch update instead of a new one reverting the first. I hope this is OK. -mm regularly replaces patches with newer versions, so that ought to be fine. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/