Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754495AbbLYBeV (ORCPT ); Thu, 24 Dec 2015 20:34:21 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:51053 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753812AbbLYBeT (ORCPT ); Thu, 24 Dec 2015 20:34:19 -0500 X-Originating-IP: 50.39.163.18 Date: Thu, 24 Dec 2015 17:34:09 -0800 From: Josh Triplett To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: linux-kernel@vger.kernel.org, Jeff Dike , Richard Weinberger , user-mode-linux-devel@lists.sourceforge.net, "Paul E . McKenney" , Michal Marek , Andrew Morton , Linus Torvalds , stable@vger.kernel.org Subject: Re: [PATCH v3] um: Fix build error and kconfig for i386 Message-ID: <20151225013409.GC12977@x> References: <1450959131-5113-1-git-send-email-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1450959131-5113-1-git-send-email-mic@digikod.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1926 Lines: 47 On Thu, Dec 24, 2015 at 01:12:11PM +0100, Micka?l Sala?n wrote: > Fix build error by generating elfcore.o only when ELF_CORE (depending on > COREDUMP) is selected: > > arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs': > (.text+0x3e62): undefined reference to `dump_emit' > arch/x86/um/built-in.o: In function `elf_core_write_extra_data': > (.text+0x3eef): undefined reference to `dump_emit' > > Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT") > Signed-off-by: Micka?l Sala?n > Cc: Jeff Dike > Cc: Richard Weinberger > Cc: Josh Triplett > Cc: Paul E. McKenney > Cc: Michal Marek > Cc: Andrew Morton > Cc: Linus Torvalds It looks like ELF_CORE depends on COREDUMP, but not on BINFMT_ELF. Should it? What happens if you build this with ELF_CORE=y and BINFMT_ELF=n? Does that configuration even make sense? > arch/x86/um/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/um/Makefile b/arch/x86/um/Makefile > index a8fecc226946..3ee2bb6b440b 100644 > --- a/arch/x86/um/Makefile > +++ b/arch/x86/um/Makefile > @@ -17,7 +17,7 @@ obj-y = bug.o bugs_$(BITS).o delay.o fault.o ksyms.o ldt.o \ > ifeq ($(CONFIG_X86_32),y) > > obj-y += checksum_32.o > -obj-$(CONFIG_BINFMT_ELF) += elfcore.o > +obj-$(CONFIG_ELF_CORE) += elfcore.o > > subarch-y = ../lib/string_32.o ../lib/atomic64_32.o ../lib/atomic64_cx8_32.o > subarch-$(CONFIG_RWSEM_XCHGADD_ALGORITHM) += ../lib/rwsem.o > -- > 2.6.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/