Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754808AbbLYHqT (ORCPT ); Fri, 25 Dec 2015 02:46:19 -0500 Received: from mail-pf0-f179.google.com ([209.85.192.179]:33980 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752938AbbLYHqP (ORCPT ); Fri, 25 Dec 2015 02:46:15 -0500 Date: Fri, 25 Dec 2015 15:41:28 +0800 From: Peter Chen To: Geliang Tang Cc: Peter Chen , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/9] usb: chipidea: debug: use list_for_each_entry Message-ID: <20151225074128.GA9700@shlinux2> References: <1ec91b8ad8d81a446e08f3c4f15f2d3df620b186.1450455485.git.geliangtang@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1660 Lines: 48 On Sat, Dec 19, 2015 at 12:34:31AM +0800, Geliang Tang wrote: > Use list_for_each_entry() instead of list_for_each() to simplify > the code. > > Signed-off-by: Geliang Tang > --- > drivers/usb/chipidea/debug.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c > index a4f7db2..de5c509 100644 > --- a/drivers/usb/chipidea/debug.c > +++ b/drivers/usb/chipidea/debug.c > @@ -172,7 +172,6 @@ static int ci_requests_show(struct seq_file *s, void *data) > { > struct ci_hdrc *ci = s->private; > unsigned long flags; > - struct list_head *ptr = NULL; > struct ci_hw_req *req = NULL; > struct td_node *node, *tmpnode; > unsigned i, j, qsize = sizeof(struct ci_hw_td)/sizeof(u32); > @@ -184,9 +183,7 @@ static int ci_requests_show(struct seq_file *s, void *data) > > spin_lock_irqsave(&ci->lock, flags); > for (i = 0; i < ci->hw_ep_max; i++) > - list_for_each(ptr, &ci->ci_hw_ep[i].qh.queue) { > - req = list_entry(ptr, struct ci_hw_req, queue); > - > + list_for_each_entry(req, &ci->ci_hw_ep[i].qh.queue, queue) { > list_for_each_entry_safe(node, tmpnode, &req->tds, td) { > seq_printf(s, "EP=%02i: TD=%08X %s\n", > i % (ci->hw_ep_max / 2), > -- > 2.5.0 > It is ok for chipidea part, I will queue it, you don't need to re-send it again -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/