Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753647AbbLYPKN (ORCPT ); Fri, 25 Dec 2015 10:10:13 -0500 Received: from a.ns.miles-group.at ([95.130.255.143]:11950 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753048AbbLYPKH (ORCPT ); Fri, 25 Dec 2015 10:10:07 -0500 Subject: Re: [PATCH v2] um: Fix build error and kconfig for i386 To: Josh Triplett , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8?= =?UTF-8?Q?n?= References: <1450875553-17717-1-git-send-email-mic@digikod.net> <20151223214212.GA1300@x> <567BE089.8030903@digikod.net> <20151225012613.GA12977@x> Cc: linux-kernel@vger.kernel.org, Jeff Dike , user-mode-linux-devel@lists.sourceforge.net, "Paul E . McKenney" , Michal Marek , Andrew Morton , Linus Torvalds , stable@vger.kernel.org From: Richard Weinberger Message-ID: <567D5C48.7020900@nod.at> Date: Fri, 25 Dec 2015 16:10:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151225012613.GA12977@x> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1932 Lines: 43 Am 25.12.2015 um 02:26 schrieb Josh Triplett: > On Thu, Dec 24, 2015 at 01:09:45PM +0100, Micka?l Sala?n wrote: >> >> On 23/12/2015 22:42, Josh Triplett wrote: >>> On Wed, Dec 23, 2015 at 01:59:13PM +0100, Micka?l Sala?n wrote: >>>> Fix build error by selecting COREDUMP when X86_32 is selected: >>>> >>>> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs': >>>> (.text+0x3e62): undefined reference to `dump_emit' >>>> arch/x86/um/built-in.o: In function `elf_core_write_extra_data': >>>> (.text+0x3eef): undefined reference to `dump_emit' >>>> >>>> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT") >>>> Signed-off-by: Micka?l Sala?n >>>> Cc: Jeff Dike >>>> Cc: Richard Weinberger >>>> Cc: Josh Triplett >>>> Cc: Paul E. McKenney >>>> Cc: Michal Marek >>>> Cc: Andrew Morton >>>> Cc: Linus Torvalds >>> >>> I suppose um doesn't care deeply about binary size, but ideally I would >>> suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when >>> CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF. >> >> That looks better! Since the first patch has been added to the mmots tree (but not yet in mmotm) I'll send a patch update instead of a new one reverting the first. I hope this is OK. > > -mm regularly replaces patches with newer versions, so that ought to be > fine. Usually non-trivial UML stuff goes thought me. As Josh noted, just post an updated version of the patch. Either me or Andrew will pick it up. Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/