Message-ID: <1451088307.12498.3.camel@perches.com>
Subject: Re: [PATCH v2 15/16] checkpatch: Add warning on deprecated
 walk_iomem_res
From: Joe Perches <joe@perches.com>
To: Toshi Kani <toshi.kani@hpe.com>, akpm@linux-foundation.org, bp@alien8.de
Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>
Date: Fri, 25 Dec 2015 16:05:07 -0800
In-Reply-To: <1451081365-15190-15-git-send-email-toshi.kani@hpe.com>
References: <1451081365-15190-1-git-send-email-toshi.kani@hpe.com>
	 <1451081365-15190-15-git-send-email-toshi.kani@hpe.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1069
Lines: 29

On Fri, 2015-12-25 at 15:09 -0700, Toshi Kani wrote:
> Use of walk_iomem_res() is deprecated in new code.??Change
> checkpatch.pl to check new use of walk_iomem_res() and suggest
> to use walk_iomem_res_desc() instead.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -3424,6 +3424,12 @@ sub process {
> ?			}
> ?		}
> ?
> +# check for uses of walk_iomem_res()
> +		if ($line =~ /\bwalk_iomem_res\(/) {
> +			WARN("walk_iomem_res",
> +			?????"Use of walk_iomem_res is deprecated, please use walk_iomem_res_desc instead\n" . $herecurr)
> +		}
> +
> ?# check for new typedefs, only function parameters and sparse annotations
> ?# make sense.
> ?		if ($line =~ /\btypedef\s/ &&

There are 6 uses of this function in the entire kernel tree.
Why not just change them, remove the function and avoid this?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/