Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751257AbbLZHtJ (ORCPT ); Sat, 26 Dec 2015 02:49:09 -0500 Received: from sauhun.de ([89.238.76.85]:49119 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751044AbbLZHtG (ORCPT ); Sat, 26 Dec 2015 02:49:06 -0500 Date: Sat, 26 Dec 2015 08:48:59 +0100 From: Wolfram Sang To: SF Markus Elfring Cc: linux-i2c@vger.kernel.org, kbuild-all@01.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: Re: [PATCH v2] i2c-core: One function call less in acpi_i2c_space_handler() after error detection Message-ID: <20151226074859.GA905@tetsubishi> References: <201512261449.pmBxYtq3%fengguang.wu@intel.com> <567E3CF3.10606@users.sourceforge.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FL5UXtIhxfXey3p5" Content-Disposition: inline In-Reply-To: <567E3CF3.10606@users.sourceforge.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1550 Lines: 40 --FL5UXtIhxfXey3p5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > The kfree() function was called in one case by the > acpi_i2c_space_handler() function during error handling > even if the passed variable "client" contained a null pointer. This is OK. kfree() is known to be NULL-tolerant and we rely on it in various places to keep the code simpler. --FL5UXtIhxfXey3p5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWfkZrAAoJEBQN5MwUoCm2NXkP/3T9Btt307u289g31NAzHAZJ R58vKBGLhZBdAhOZRtfCFMQ5kB0TfrKDdalObUvU3QnjGJgJO92iueIUIRCkYxLi tf/ORn6ZBOmrb412c8lQNZv96lG8/mBvaqUoQQVwojAJaW8R9xDhyqcutz26Uthb VkjM6tEfVD9G/qzeoQ9per5CR3WrZbde4iX0mJNMfUWkqH5sK/4jpdKoDXtBQ3Lq bfsGCZZI67EBbCJxNfhCv5iAUkZt1INQ1TGE93mIf4XPYmGeXm1oh7GXyTZf1k3H xFCTD5bFezbLIHlrcS3SfgnTsOmMAIu2uXiuE38WV3eyjIVcwrCzhQM15kW8Rw1T WaLkCzkkrO8q3v74ugfEHBbTpTwJVQHw/Tzb50tQG6Y5s225ebcn6j7NVMpa/lAs VTEZlhQwaswcsFKPp7fwmmwiX6kz/6ZpfpQ0MVaqyFDcg3M7pZz0ioyNWaxdwpWV sW6E3XLvnBEsYHIplAcdw+sXMEocVCnUySgmpDoHOK7SCyzV7GwfuGPpcJBrh99A jOhmHAGpwTMleUG2pEsYNiuJ4Mk0fueOlBxwvDOPA6f0Pwc5PyhRcJR/gqMsvr4D /HuGviOmH2rPKpU7dk/7DmbPZqbLioiT7QDRVHm1aTF1HRWMwqbCNao8pJOIfvXC VfElt6PDuzAaxZgUHKL3 =olSG -----END PGP SIGNATURE----- --FL5UXtIhxfXey3p5-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/