Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752534AbbLZQC6 (ORCPT ); Sat, 26 Dec 2015 11:02:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57143 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750885AbbLZQC4 (ORCPT ); Sat, 26 Dec 2015 11:02:56 -0500 Date: Sun, 27 Dec 2015 00:05:22 +0800 From: Minfei Huang To: Toshi Kani Cc: akpm@linux-foundation.org, bp@alien8.de, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dan Williams , Dave Young , x86@kernel.org, linux-nvdimm@ml01.01.org, kexec@lists.infradead.org Subject: Re: [PATCH v2 14/16] x86,nvdimm,kexec: Use walk_iomem_res_desc() for iomem search Message-ID: <20151226160522.GA28533@dhcp-128-25.nay.redhat.com> References: <1451081365-15190-1-git-send-email-toshi.kani@hpe.com> <1451081365-15190-14-git-send-email-toshi.kani@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1451081365-15190-14-git-send-email-toshi.kani@hpe.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1313 Lines: 35 Ccing kexec maillist. On 12/25/15 at 03:09pm, Toshi Kani wrote: > diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c > index c245085..e2bd737 100644 > --- a/kernel/kexec_file.c > +++ b/kernel/kexec_file.c > @@ -522,10 +522,10 @@ int kexec_add_buffer(struct kimage *image, char *buffer, unsigned long bufsz, > > /* Walk the RAM ranges and allocate a suitable range for the buffer */ > if (image->type == KEXEC_TYPE_CRASH) > - ret = walk_iomem_res("Crash kernel", > - IORESOURCE_SYSTEM_RAM | IORESOURCE_BUSY, > - crashk_res.start, crashk_res.end, kbuf, > - locate_mem_hole_callback); > + ret = walk_iomem_res_desc(IORES_DESC_CRASH_KERNEL, Since crashk_res's desc has been assigned to IORES_DESC_CRASH_KERNEL, it is better to use crashk_res.desc, instead of using IORES_DESC_CRASH_KERNEL directly. Thanks Minfei > + IORESOURCE_SYSTEM_RAM | IORESOURCE_BUSY, > + crashk_res.start, crashk_res.end, kbuf, > + locate_mem_hole_callback); > else > ret = walk_system_ram_res(0, -1, kbuf, > locate_mem_hole_callback); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/