Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753344AbbLZRk6 (ORCPT ); Sat, 26 Dec 2015 12:40:58 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:15856 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240AbbLZRk4 (ORCPT ); Sat, 26 Dec 2015 12:40:56 -0500 X-IronPort-AV: E=Sophos;i="5.20,482,1444687200"; d="scan'208";a="194436554" Date: Sat, 26 Dec 2015 18:40:54 +0100 (CET) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Sergei Shtylyov cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/7] drivers: net: cpsw: fix error return code In-Reply-To: <567ED019.3000407@cogentembedded.com> Message-ID: References: <1451143726-28195-1-git-send-email-Julia.Lawall@lip6.fr> <1451143726-28195-7-git-send-email-Julia.Lawall@lip6.fr> <567ED019.3000407@cogentembedded.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1435 Lines: 53 > > diff --git a/drivers/net/ethernet/ti/cpsw.c > > b/drivers/net/ethernet/ti/cpsw.c > > index 3409e80..6a76992 100644 > > --- a/drivers/net/ethernet/ti/cpsw.c > > +++ b/drivers/net/ethernet/ti/cpsw.c > > @@ -2448,8 +2448,10 @@ static int cpsw_probe(struct platform_device *pdev) > > > > /* RX IRQ */ > > irq = platform_get_irq(pdev, 1); > > - if (irq < 0) > > + if (irq < 0) { > > + ret = -ENOENT; > > Why not just propagate an error returned by that function? OK, I did what was done a few lines before in the same function: ndev->irq = platform_get_irq(pdev, 1); if (ndev->irq < 0) { dev_err(priv->dev, "error getting irq resource\n"); ret = -ENOENT; goto clean_ale_ret; } Maybe they should all be changed? julia > > goto clean_ale_ret; > > + } > > > > priv->irqs_table[0] = irq; > > ret = devm_request_irq(&pdev->dev, irq, cpsw_rx_interrupt, > > @@ -2461,8 +2463,10 @@ static int cpsw_probe(struct platform_device *pdev) > > > > /* TX IRQ */ > > irq = platform_get_irq(pdev, 2); > > - if (irq < 0) > > + if (irq < 0) { > > + ret = -ENOENT; > > Likewise? > > [...] > > MBR, Sergei > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/