Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752934AbbL0Mjj (ORCPT ); Sun, 27 Dec 2015 07:39:39 -0500 Received: from mail-yk0-f177.google.com ([209.85.160.177]:36712 "EHLO mail-yk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751103AbbL0Mjh (ORCPT ); Sun, 27 Dec 2015 07:39:37 -0500 MIME-Version: 1.0 In-Reply-To: References: Date: Sun, 27 Dec 2015 14:39:36 +0200 Message-ID: Subject: Re: [PATCH 7/9] serial: 8250_pci: use to_pci_dev() From: Andy Shevchenko To: Geliang Tang Cc: Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1320 Lines: 37 On Sun, Dec 27, 2015 at 12:46 PM, Geliang Tang wrote: > Use to_pci_dev() instead of open-coding it. > > Signed-off-by: Geliang Tang > --- > drivers/tty/serial/8250/8250_pci.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c > index 4097f3f..afdd2c67 100644 > --- a/drivers/tty/serial/8250/8250_pci.c > +++ b/drivers/tty/serial/8250/8250_pci.c > @@ -1538,8 +1538,7 @@ static int pci_fintek_rs485_config(struct uart_port *port, > { > u8 setting; > u8 *index = (u8 *) port->private_data; > - struct pci_dev *pci_dev = container_of(port->dev, struct pci_dev, > - dev); > + struct pci_dev *pci_dev = to_pci_dev(port->dev); I would make it first line in this block. Otherwise, Reviewed-by: Andy Shevchenko > > pci_read_config_byte(pci_dev, 0x40 + 8 * *index + 7, &setting); > -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/