Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755376AbbL0OfP (ORCPT ); Sun, 27 Dec 2015 09:35:15 -0500 Received: from mail-yk0-f169.google.com ([209.85.160.169]:34420 "EHLO mail-yk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754053AbbL0OfN (ORCPT ); Sun, 27 Dec 2015 09:35:13 -0500 MIME-Version: 1.0 In-Reply-To: <20151221161629.GG4227@codeblueprint.co.uk> References: <1450402114-3606-1-git-send-email-elliott@hpe.com> <1450402114-3606-5-git-send-email-elliott@hpe.com> <20151221161629.GG4227@codeblueprint.co.uk> Date: Sun, 27 Dec 2015 16:35:12 +0200 Message-ID: Subject: Re: [PATCH 4/4] x86/efi: print size and base in binary units in efi_print_memmap From: Andy Shevchenko To: Matt Fleming Cc: Robert Elliott , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "x86@kernel.org" , linux-efi@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2955 Lines: 74 On Mon, Dec 21, 2015 at 6:16 PM, Matt Fleming wrote: > On Thu, 17 Dec, at 07:28:34PM, Robert Elliott wrote: >> Print the base address for each range in decimal alongside the size. >> Use a "(size @ base)" format similar to the fake_memmap kernel parameter. >> >> Print the range and base in the best-fit B, KiB, MiB, etc. units rather >> than always MiB. This avoids rounding, which can be misleading. >> >> Use proper IEC binary units (KiB, MiB, etc.) rather than misuse SI >> decimal units (KB, MB, etc.). >> >> old: >> efi: mem61: [Persistent Memory | | | | | | | |WB|WT|WC|UC] range=[0x0000000880000000-0x0000000c7fffffff) (16384MB) >> >> new: >> efi: mem61: [Persistent Memory | | | | | | | |WB|WT|WC|UC] range=[0x0000000880000000-0x0000000c7fffffff] (16 GiB @ 34 GiB) >> >> Signed-off-by: Robert Elliott >> --- >> arch/x86/platform/efi/efi.c | 27 ++++++++++++++++++++++++--- >> 1 file changed, 24 insertions(+), 3 deletions(-) > > I'm not at all sure of the value of printing the physical address as a > size. I would have thought that you'd have to convert it back to an > address whenever you wanted to use it anyway. > >> diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c >> index 635a955..030ba91 100644 >> --- a/arch/x86/platform/efi/efi.c >> +++ b/arch/x86/platform/efi/efi.c >> @@ -222,6 +222,25 @@ int __init efi_memblock_x86_reserve_range(void) >> return 0; >> } >> >> +char * __init efi_size_format(char *buf, size_t size, u64 bytes) >> +{ >> + if (!bytes || (bytes & 0x3ff)) >> + snprintf(buf, size, "%llu B", bytes); >> + else if (bytes & 0xfffff) >> + snprintf(buf, size, "%llu KiB", bytes >> 10); >> + else if (bytes & 0x3fffffff) >> + snprintf(buf, size, "%llu MiB", bytes >> 20); >> + else if (bytes & 0xffffffffff) >> + snprintf(buf, size, "%llu GiB", bytes >> 30); >> + else if (bytes & 0x3ffffffffffff) >> + snprintf(buf, size, "%llu TiB", bytes >> 40); >> + else if (bytes & 0xfffffffffffffff) >> + snprintf(buf, size, "%llu PiB", bytes >> 50); >> + else >> + snprintf(buf, size, "%llu EiB", bytes >> 60); >> + return buf; For me it looks like ffs with name in the table can be used. >> +} >> + > > Can we use string_get_size() instead of rolling our own function? > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/