Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754187AbbL0USF (ORCPT ); Sun, 27 Dec 2015 15:18:05 -0500 Received: from spo001.leaseweb.nl ([83.149.101.17]:43680 "EHLO spo001.leaseweb.nl" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751872AbbL0USA (ORCPT ); Sun, 27 Dec 2015 15:18:00 -0500 Date: Sun, 27 Dec 2015 21:17:53 +0100 From: Wim Van Sebroeck To: Geliang Tang Cc: Guenter Roeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/10] watchdog: cadence_wdt: use to_platform_device() Message-ID: <20151227201753.GC25197@spo001.leaseweb.nl> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1565 Lines: 48 Hi Geliang, > Use to_platform_device() instead of open-coding it. > > Signed-off-by: Geliang Tang > --- > drivers/watchdog/cadence_wdt.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c > index abf64eb..4dda902 100644 > --- a/drivers/watchdog/cadence_wdt.c > +++ b/drivers/watchdog/cadence_wdt.c > @@ -421,8 +421,7 @@ static void cdns_wdt_shutdown(struct platform_device *pdev) > */ > static int __maybe_unused cdns_wdt_suspend(struct device *dev) > { > - struct platform_device *pdev = container_of(dev, > - struct platform_device, dev); > + struct platform_device *pdev = to_platform_device(dev); > struct cdns_wdt *wdt = platform_get_drvdata(pdev); > > cdns_wdt_stop(&wdt->cdns_wdt_device); > @@ -440,8 +439,7 @@ static int __maybe_unused cdns_wdt_suspend(struct device *dev) > static int __maybe_unused cdns_wdt_resume(struct device *dev) > { > int ret; > - struct platform_device *pdev = container_of(dev, > - struct platform_device, dev); > + struct platform_device *pdev = to_platform_device(dev); > struct cdns_wdt *wdt = platform_get_drvdata(pdev); > > ret = clk_prepare_enable(wdt->clk); > -- > 2.5.0 > > Patch added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/