Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751959AbbL1BE3 (ORCPT ); Sun, 27 Dec 2015 20:04:29 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:55838 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751453AbbL1BEV (ORCPT ); Sun, 27 Dec 2015 20:04:21 -0500 Subject: Re: [PATCH 1/6] regulator: lp872x: Add missing of_match in regulators descriptions To: Paul Kocialkowski References: <1450868319-20513-1-git-send-email-contact@paulk.fr> <1450868319-20513-2-git-send-email-contact@paulk.fr> CC: , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , =?UTF-8?Q?Beno=c3=aet_Cousson?= , Tony Lindgren , Liam Girdwood , Mark Brown , , , From: Milo Kim Message-ID: <56808AAC.4070801@ti.com> Date: Mon, 28 Dec 2015 10:04:44 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1450868319-20513-2-git-send-email-contact@paulk.fr> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4858 Lines: 143 On 23/12/15 19:58, Paul Kocialkowski wrote: > In order to select the regulators via of_find_regulator_by_node (and thus use > them in devicetree), defining of_match for each regulator is required. > > Signed-off-by: Paul Kocialkowski Acked-by: Milo Kim > --- > drivers/regulator/lp872x.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/regulator/lp872x.c b/drivers/regulator/lp872x.c > index e5af072..9412353 100644 > --- a/drivers/regulator/lp872x.c > +++ b/drivers/regulator/lp872x.c > @@ -520,6 +520,7 @@ static struct regulator_ops lp8725_buck_ops = { > static struct regulator_desc lp8720_regulator_desc[] = { > { > .name = "ldo1", > + .of_match = of_match_ptr("ldo1"), > .id = LP8720_ID_LDO1, > .ops = &lp872x_ldo_ops, > .n_voltages = ARRAY_SIZE(lp872x_ldo_vtbl), > @@ -533,6 +534,7 @@ static struct regulator_desc lp8720_regulator_desc[] = { > }, > { > .name = "ldo2", > + .of_match = of_match_ptr("ldo2"), > .id = LP8720_ID_LDO2, > .ops = &lp872x_ldo_ops, > .n_voltages = ARRAY_SIZE(lp872x_ldo_vtbl), > @@ -546,6 +548,7 @@ static struct regulator_desc lp8720_regulator_desc[] = { > }, > { > .name = "ldo3", > + .of_match = of_match_ptr("ldo3"), > .id = LP8720_ID_LDO3, > .ops = &lp872x_ldo_ops, > .n_voltages = ARRAY_SIZE(lp872x_ldo_vtbl), > @@ -559,6 +562,7 @@ static struct regulator_desc lp8720_regulator_desc[] = { > }, > { > .name = "ldo4", > + .of_match = of_match_ptr("ldo4"), > .id = LP8720_ID_LDO4, > .ops = &lp872x_ldo_ops, > .n_voltages = ARRAY_SIZE(lp8720_ldo4_vtbl), > @@ -572,6 +576,7 @@ static struct regulator_desc lp8720_regulator_desc[] = { > }, > { > .name = "ldo5", > + .of_match = of_match_ptr("ldo5"), > .id = LP8720_ID_LDO5, > .ops = &lp872x_ldo_ops, > .n_voltages = ARRAY_SIZE(lp872x_ldo_vtbl), > @@ -585,6 +590,7 @@ static struct regulator_desc lp8720_regulator_desc[] = { > }, > { > .name = "buck", > + .of_match = of_match_ptr("buck"), > .id = LP8720_ID_BUCK, > .ops = &lp8720_buck_ops, > .n_voltages = ARRAY_SIZE(lp8720_buck_vtbl), > @@ -599,6 +605,7 @@ static struct regulator_desc lp8720_regulator_desc[] = { > static struct regulator_desc lp8725_regulator_desc[] = { > { > .name = "ldo1", > + .of_match = of_match_ptr("ldo1"), > .id = LP8725_ID_LDO1, > .ops = &lp872x_ldo_ops, > .n_voltages = ARRAY_SIZE(lp872x_ldo_vtbl), > @@ -612,6 +619,7 @@ static struct regulator_desc lp8725_regulator_desc[] = { > }, > { > .name = "ldo2", > + .of_match = of_match_ptr("ldo2"), > .id = LP8725_ID_LDO2, > .ops = &lp872x_ldo_ops, > .n_voltages = ARRAY_SIZE(lp872x_ldo_vtbl), > @@ -625,6 +633,7 @@ static struct regulator_desc lp8725_regulator_desc[] = { > }, > { > .name = "ldo3", > + .of_match = of_match_ptr("ldo3"), > .id = LP8725_ID_LDO3, > .ops = &lp872x_ldo_ops, > .n_voltages = ARRAY_SIZE(lp872x_ldo_vtbl), > @@ -638,6 +647,7 @@ static struct regulator_desc lp8725_regulator_desc[] = { > }, > { > .name = "ldo4", > + .of_match = of_match_ptr("ldo4"), > .id = LP8725_ID_LDO4, > .ops = &lp872x_ldo_ops, > .n_voltages = ARRAY_SIZE(lp872x_ldo_vtbl), > @@ -651,6 +661,7 @@ static struct regulator_desc lp8725_regulator_desc[] = { > }, > { > .name = "ldo5", > + .of_match = of_match_ptr("ldo5"), > .id = LP8725_ID_LDO5, > .ops = &lp872x_ldo_ops, > .n_voltages = ARRAY_SIZE(lp872x_ldo_vtbl), > @@ -664,6 +675,7 @@ static struct regulator_desc lp8725_regulator_desc[] = { > }, > { > .name = "lilo1", > + .of_match = of_match_ptr("lilo1"), > .id = LP8725_ID_LILO1, > .ops = &lp872x_ldo_ops, > .n_voltages = ARRAY_SIZE(lp8725_lilo_vtbl), > @@ -677,6 +689,7 @@ static struct regulator_desc lp8725_regulator_desc[] = { > }, > { > .name = "lilo2", > + .of_match = of_match_ptr("lilo2"), > .id = LP8725_ID_LILO2, > .ops = &lp872x_ldo_ops, > .n_voltages = ARRAY_SIZE(lp8725_lilo_vtbl), > @@ -690,6 +703,7 @@ static struct regulator_desc lp8725_regulator_desc[] = { > }, > { > .name = "buck1", > + .of_match = of_match_ptr("buck1"), > .id = LP8725_ID_BUCK1, > .ops = &lp8725_buck_ops, > .n_voltages = ARRAY_SIZE(lp8725_buck_vtbl), > @@ -701,6 +715,7 @@ static struct regulator_desc lp8725_regulator_desc[] = { > }, > { > .name = "buck2", > + .of_match = of_match_ptr("buck2"), > .id = LP8725_ID_BUCK2, > .ops = &lp8725_buck_ops, > .n_voltages = ARRAY_SIZE(lp8725_buck_vtbl), > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/