Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751479AbbL1Dm5 (ORCPT ); Sun, 27 Dec 2015 22:42:57 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:33948 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751166AbbL1Dmu (ORCPT ); Sun, 27 Dec 2015 22:42:50 -0500 Subject: Re: [PATCH RESEND 1/1] serial: 8250_pci: Fix real serial port count for F81504/508/512 References: <1448952881-7871-1-git-send-email-hpeter+linux_kernel@gmail.com> Cc: Andy Shevchenko , jslaby@suse.com, "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , tom_tsai@fintek.com.tw, Peter H , Peter Hung To: Greg Kroah-Hartman From: Peter Hung Message-ID: <5680AFBB.3080108@gmail.com> Date: Mon, 28 Dec 2015 11:42:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 920 Lines: 27 Hi Greg, Andy Shevchenko 於 2015/12/13 上午 09:08 寫道: > First of all, maybe you can consider to split this part of the driver > to separate one? (Like we did for 8250_mid.c). It seems 8250_pci is > too bloated. But it's just an idea, maybe for future. > Did you have reviewed this patch? Please skip this patch if not reviewed. The F81504/508/512 is multi-function card. It contains Serial/GPIO functions. It maybe enlarge the scale of 8250_pci.c and make it less maintainable if we add GPIOLIB support into 8250_pci.c Could I split the F81504/508/512 driver from 8250_pci.c into a new module file and implements GPIOLIB? Thanks -- With Best Regards, Peter Hung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/