Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751739AbbL1IYj (ORCPT ); Mon, 28 Dec 2015 03:24:39 -0500 Received: from mga09.intel.com ([134.134.136.24]:32324 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751275AbbL1IYg (ORCPT ); Mon, 28 Dec 2015 03:24:36 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,490,1444719600"; d="scan'208";a="716024818" Subject: Re: [Bugfix v2 1/5] x86/irq: Do not reuse struct apic_chip_data.old_domain as temporary buffer To: Jeremiah Mahler , Thomas Gleixner , Joe Lawrence , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Borislav Petkov , andy.shevchenko@gmail.com, Guenter Roeck , linux-kernel@vger.kernel.org References: <1450880014-11741-1-git-send-email-jiang.liu@linux.intel.com> <20151224051539.GB1845@hudson.localdomain> From: Jiang Liu Organization: Intel Message-ID: <5680F1C0.7080505@linux.intel.com> Date: Mon, 28 Dec 2015 16:24:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20151224051539.GB1845@hudson.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1883 Lines: 47 On 2015/12/24 13:15, Jeremiah Mahler wrote: > Jiang, > > On Wed, Dec 23, 2015 at 10:13:26PM +0800, Jiang Liu wrote: >> Function __assign_irq_vector() makes use of apic_chip_data.old_domain >> as a temporary buffer, which causes trouble to rollback logic in case of >> failure. So use a dedicated temporary buffer for __assign_irq_vector(). >> >> Signed-off-by: Jiang Liu >> --- >> arch/x86/kernel/apic/vector.c | 9 +++++---- >> 1 file changed, 5 insertions(+), 4 deletions(-) > [...] > > I tried this patch and the rest in the series but unfortunately > the bug is still present. > > [ 10.184649] wlan0: authenticated > [ 10.187883] wlan0: associate with 02:1a:11:fb:90:1c (try 1/3) > [ 10.191574] do_IRQ: 0.35 No irq handler for vector > [ 10.191589] do_IRQ: 0.35 No irq handler for vector > [ 10.198159] do_IRQ: 0.35 No irq handler for vector > [ 10.198165] do_IRQ: 0.35 No irq handler for vector > [ 10.200534] wlan0: RX AssocResp from 02:1a:11:fb:90:1c (capab=0x431 > status=0 aid=1) > [ 10.204611] wlan0: associated > [ 10.238883] do_IRQ: 0.35 No irq handler for vector > [ 10.238892] do_IRQ: 0.35 No irq handler for vector > [ 10.280716] do_IRQ: 0.35 No irq handler for vector > [ 10.281083] do_IRQ: 0.35 No irq handler for vector > [ 10.286484] do_IRQ: 0.35 No irq handler for vector > ... > Hi Jeremiah, Could you please help to confirm which commit caused the regression? 1) x86/irq: Do not reuse struct apic_chip_data.old_domain as temporary buffer 2) x86/irq: Fix a race condition between vector assigning and cleanup Thanks, Gerry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/