Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752102AbbL1KgK (ORCPT ); Mon, 28 Dec 2015 05:36:10 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.47.9]:36395 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751906AbbL1KgH (ORCPT ); Mon, 28 Dec 2015 05:36:07 -0500 Subject: Re: [PATCH v5 04/20] clocksource: Add NPS400 timers driver To: Daniel Lezcano , Noam Camus , kbuild test robot References: <1451222619-3610-5-git-send-email-noamc@ezchip.com> <201512272200.4NfpC6DB%fengguang.wu@intel.com> <5680FA14.4010107@linaro.org> CC: "kbuild-all@01.org" , "linux-snps-arc@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Chris Metcalf , "marc.zyngier@arm.com" , "Rob Herring" , Thomas Gleixner , "John Stultz" Newsgroups: gmane.linux.kernel,gmane.linux.kernel.arc From: Vineet Gupta Message-ID: <56811074.9020102@synopsys.com> Date: Mon, 28 Dec 2015 16:05:32 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5680FA14.4010107@linaro.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.12.197.208] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1318 Lines: 41 On Monday 28 December 2015 02:30 PM, Daniel Lezcano wrote: >>> reproduce: >>> # save the attached .config to linux build tree >>> make ARCH=i386 >> >> This is meant for ARC only (not i386), I will add to the Kconfig file a >> dependency on my platform. > > Hi Noam, > > for compilation test coverage it would be nice to not restrict the to ARC only but > change the write_aux_reg to a common name across the different arch if possible. > > -- Daniel Hi Daniel, AUX registers is a ARC specific mechanism used to access some of the core functionality (intc, caches, ....) which other arches likely do via MMIO. I don't think a generic abstraction exists. And IMHO it doesn't make sense to invent one given this may not map directly to other arches. This was one of the key reasons arc intc/timers were not added to drivers/* in first place. I do agree with compilation test coverage aspect though. Maybe we add a *hack* to include/soc/nps/common.h #ifndef __ARC__ #define write_aux_reg(r, v) #define read_aux_reg(r) 0 #endif What say you ? -Vineet -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/